worker/uniter/relation: relationsSuite.TestCommitHook tests fail

[Dave Cheney]

FAIL: relations_test.go:410: relationsSuite.TestCommitHook

request 0, Life
request 1, JoinedRelations
request 2, RelationById
request 3, Relation
request 4, Relation
request 5, Watch
request 6, EnterScope
request 6, Next
relations_test.go:94:
request 7, Stop
    c.Check(objType, gc.Equals, call.facadeName)
... obtained string = "NotifyWatcher"
... expected string = "Uniter"

relations_test.go:95:
    c.Check(version, gc.Equals, call.version)
... obtained int = 0
... expected int = 2

relations_test.go:96:
    c.Check(id, gc.Equals, call.id)
... obtained string = "1"
... expected string = ""

relations_test.go:97:
    c.Check(request, gc.Equals, call.request)
... obtained string = "Next"
... expected string = "EnterScope"

relations_test.go:98:
    c.Check(arg, jc.DeepEquals, call.args)
... obtained = nil
... expected params.RelationUnits = params.RelationUnits{RelationUnits:[]params.RelationUnit{params.RelationUnit{Relation:"relation-wordpress.db#mysql.db", Unit:"unit-wordpress-0"}}}
... mismatch at top level: nil vs non-nil mismatch; obtained <nil>; expected params.RelationUnits{RelationUnits:[]params.RelationUnit{params.RelationUnit{Relation:"relation-wordpress.db#mysql.db", Unit:"unit-wordpress-0"}}}

request 8, GetPrincipal
relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:94:
    c.Check(objType, gc.Equals, call.facadeName)
... obtained string = "Uniter"
... expected string = "NotifyWatcher"

relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:95:
    c.Check(version, gc.Equals, call.version)
... obtained int = 2
... expected int = 0

relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:96:
    c.Check(id, gc.Equals, call.id)
... obtained string = ""
... expected string = "1"

relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:97:
    c.Check(request, gc.Equals, call.request)
... obtained string = "GetPrincipal"
... expected string = "Next"

relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:98:
    c.Check(arg, jc.DeepEquals, call.args)
... obtained params.Entities = params.Entities{Entities:[]params.Entity{params.Entity{Tag:"unit-wordpress-0"}}}
... expected = nil
... mismatch at top level: nil vs non-nil mismatch; obtained params.Entities{Entities:[]params.Entity{params.Entity{Tag:"unit-wordpress-0"}}}; expected <nil>

relations_test.go:421:
    r := s.assertHookRelationJoined(c, &numCalls, apiCalls...)
relations_test.go:281:
    c.Assert(err, jc.ErrorIsNil)
... value *errors.Err = &errors.Err{message:"", cause:(*params.Error)(0xc8203f6c00), previous:(*errors.Err)(0xc8201d8f50), file:"github.com/juju/juju/worker/uniter/relation/relations.go", line:69} ("watcher")
... error stack:
 watcher
 github.com/juju/juju/worker/uniter/relation/relations.go:408:
 github.com/juju/juju/worker/uniter/relation/relations.go:180:
 github.com/juju/juju/worker/uniter/relation/relations.go:69:

----------------------------------------------------------------------
FAIL: relations_test.go:384: relationsSuite.TestHookRelationBroken

request 0, Life
request 1, JoinedRelations
request 2, RelationById
request 3, Relation
request 4, Relation
request 5, Watch
request 6, EnterScope
request 7, Stop
request 7, Next
relations_test.go:97:
    c.Check(request, gc.Equals, call.request)
... obtained string = "Next"
... expected string = "Stop"

request 9, Next
relations_test.go:94:
request 10, GetPrincipal
relations_test.go:389:
    c.Check(objType, gc.Equals, call.facadeName)
... obtained string = "NotifyWatcher"
... expected string = "Uniter"

relations_test.go:95:
    r := s.assertHookRelationDeparted(c, &numCalls, apiCalls...)
relations_test.go:282:
    c.Check(version, gc.Equals, call.version)
... obtained int = 0
... expected int = 2

relations_test.go:96:
    c.Assert(*numCalls, gc.Equals, 10)
... obtained int = 11
... expected int = 10

----------------------------------------------------------------------
FAIL: relations_test.go:447: relationsSuite.TestImplicitRelationNoHooks

request 0, Life
request 1, JoinedRelations
request 2, RelationById
request 3, Relation
request 4, Relation
request 5, Watch
request 6, EnterScope
request 7, Stop
request 7, Next
relations_test.go:97:
    c.Check(request, gc.Equals, call.request)
... obtained string = "Next"
... expected string = "Stop"

request 9, Next
request 10, GetPrincipal
relations_test.go:94:
relations_test.go:502:
    c.Check(objType, gc.Equals, call.facadeName)
... obtained string = "NotifyWatcher"
... expected string = "Uniter"

relations_test.go:95:
    _, err = relationsResolver.NextOp(localState, remoteState, &mockOperations{})
relations_test.go:91:
    c.Assert(index < len(apiCalls), jc.IsTrue)
... obtained bool = false

----------------------------------------------------------------------
FAIL: relations_test.go:148: relationsSuite.TestNewRelationsWithExistingRelations

request 0, Life
request 1, JoinedRelations
request 2, Relation
request 3, Relation
request 4, Watch
request 5, EnterScope
request 5, Next
relations_test.go:94:
request 6, Stop
    c.Check(objType, gc.Equals, call.facadeName)
... obtained string = "NotifyWatcher"
... expected string = "Uniter"

relations_test.go:95:
    c.Check(version, gc.Equals, call.version)
... obtained int = 0
... expected int = 2

relations_test.go:96:
    c.Check(id, gc.Equals, call.id)
... obtained string = "1"
... expected string = ""

relations_test.go:97:
    c.Check(request, gc.Equals, call.request)
... obtained string = "Next"
... expected string = "EnterScope"

relations_test.go:98:
    c.Check(arg, jc.DeepEquals, call.args)
... obtained = nil
... expected params.RelationUnits = params.RelationUnits{RelationUnits:[]params.RelationUnit{params.RelationUnit{Relation:"relation-wordpress.db#mysql.db", Unit:"unit-wordpress-0"}}}
... mismatch at top level: nil vs non-nil mismatch; obtained <nil>; expected params.RelationUnits{RelationUnits:[]params.RelationUnit{params.RelationUnit{Relation:"relation-wordpress.db#mysql.db", Unit:"unit-wordpress-0"}}}

relations_test.go:183:
    c.Assert(numCalls, gc.Equals, 8)
... obtained int = 7
... expected int = 8

--- FAIL: TestPackage (8.34s)
FAIL
exit status 1
FAIL github.com/juju/juju/worker/uniter/relation 8.508s

[Ian Booth (wallyworld)]

Removing blocker - seems to fail only on Go 1.5. Passes bot etc. Still critical, but not a blocker.