environs/config: fails if logging config is not attr=value

Bug #1478936 reported by Roger Peppe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Expired
Low
Unassigned
juju-core
Won't Fix
Medium
Unassigned

Bug Description

In environs/config/config.go, there is this code:

 levels, err := loggo.ParseConfigurationString(loggingConfig)
 if err != nil {
  return err
 }
 // If there is is no specified level for "unit", then set one.
 if _, ok := levels["unit"]; !ok {
  loggingConfig = loggingConfig + ";unit=DEBUG"
 }

This fails if loggingConfig is "DEBUG" (a valid config) because "DEBUG;unit=DEBUG" is
not a valid logging configuration.

DEBUG seems like a bad default anyway, but perhaps loggo.ParseConfiguration
could be changed to accept the above string as equivalent to "<root>=DEBUG;unit=DEBUG".

Curtis Hovey (sinzui)
tags: added: logging tech-debt
Changed in juju-core:
status: New → Triaged
importance: Undecided → Medium
Changed in juju-core:
status: Triaged → Won't Fix
Revision history for this message
Roger Peppe (rogpeppe) wrote :

This is still a valid bug that really should be fixed.

Changed in juju:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.0.1
Curtis Hovey (sinzui)
Changed in juju:
milestone: 2.0.1 → none
Revision history for this message
Anastasia (anastasia-macmood) wrote :

As this is a tech-debt item, I am lowering its Importance.

Changed in juju:
importance: Medium → Low
Revision history for this message
Canonical Juju QA Bot (juju-qa-bot) wrote :

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.

Changed in juju:
status: Triaged → Expired
tags: added: expirebugs-bot
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.