HookQueueSuite.TestAliveHookQueue failure

[Dave Cheney]

as seen in
    http://reports.vapour.ws/releases/issue/55a8183f749a56642e38ca2d

----------------------------------------------------------------------
FAIL: hookqueue_test.go:164: HookQueueSuite.TestAliveHookQueue

test 0: Nothing happens if a unit departs before its joined is run.
  step 0
  step 1
  step 2
hookqueue_test.go:175:
    expect{}.check(c, in, out)
hookqueue_test.go:306:
    c.Fatalf("got %#v", unexpected)
... Error: got hook.Info{Kind:"relation-joined", RelationId:21345, RemoteUnit:"u/0", ChangeVersion:7, StorageId:""}

OOPS: 11 passed, 1 FAILED
--- FAIL: TestPackage (0.25s)
FAIL
FAIL github.com/juju/juju/worker/uniter/relation 0.288s

[Curtis Hovey (sinzui)]

CI also sees this too. This is an example:
    http://reports.vapour.ws/releases/2883/job/run-unit-tests-precise-amd64/attempt/3108

[Aaron Bentley (abentley)]

We haven't seen this in master for 6 months. Marking incomplete.

[William Reade (fwereade)]

long fixed in master, was addressed by axw on 2015-08-20 in 10bcbc290c7

[Curtis Hovey (sinzui)]

This issue is still preventing 1.25 from passing.

[Anastasia (anastasia-macmood)]

@Andrew,

Please backport it to 1.25 as well.

[Andrew Wilkins (axwalk)]

@anastasia Sorry, but no. This was "fixed" on master because the guts of the uniter were completely rewritten last year. That's not something we can just backport.

[Alexis Bruemmer (alexis-bruemmer)]

This is not a critical functional bug and will not be addressed in 1.25. The test no longer exists on 2.0. We should note it as a known failure for 1.25 and close this bug.

[Curtis Hovey (sinzui)]

This bug contributed to the curse of the latesting 1.25 run.

[Anastasia (anastasia-macmood)]

As per release call, 1.25 needs to contain fixes for broken functionality. This test will not be fixed.