many window unit tests failures

[Curtis Hovey]

As seen in
     http://reports.vapour.ws/releases/2592/job/run-unit-tests-win2012-amd64/attempt/321
or
     http://data.vapour.ws/juju-ci/products/version-2592/run-unit-tests-win2012-amd64/build-321/consoleText

There are many unit test failures, and they look consistent across many runs.

[Martin Packman (gz)]

This is likely caused (at least in part) by the attempted fix to bug 1446871:

<https://github.com/juju/juju/pull/2124>

The symptoms, missing hook tools in tests, are the same as before the workaround in CI was instated:

<http://reports.vapour.ws/releases/2589/job/run-unit-tests-win2012-amd64/attempt/317>

[LOG] 0:01.641 INFO unit.u/0.install c:\...\agents\unit-u-0\charm>juju-log.exe deadbeef-0bad-400d-8000-4b1d0d06f00d install
[LOG] 0:01.641 INFO unit.u/0.install 'juju-log.exe' is not recognized as an internal or external command,
[LOG] 0:01.641 INFO unit.u/0.install operable program or batch file.
want unit status "idle", got "executing"; still waiting
[LOG] 0:01.647 INFO juju.worker.uniter.context handling reboot
[LOG] 0:01.647 ERROR juju.worker.uniter.operation hook "install" failed: exit status 1

[Katherine Cox-Buday (cox-katherine-e)]

I don't think that https://github.com/juju/juju/pull/2124 is causing the failures for 1.24 since this was landed in master. This actually looks like it may be a dupe of bug 1446871. What differentiates the two?

[Curtis Hovey (sinzui)]

gotesttarfile.py is forcing "PATH" and "Path" into the env. We did this to see passed before Core merged their fixes.

[Curtis Hovey (sinzui)]

To be clean the CI work around in comment #1 is to ensure PATH and Path are identical when the tests are run so that anything that calls either gets set of executables.

[Martin Packman (gz)]

There are at least two breaking changes here. On master, the envvar casing change I mentioned, on 1.24 we've got a close/rename issue:

[LOG] 0:00.736 DEBUG juju.apiserver -> [98] user-dummy-admin@local 33.0041ms {"RequestId":7,"Error":"cannot move the charm archive: replace c:\\...\\charm-download085281031 c:\\...\\cs_3a_precise_2f_wordpress-3.charm: The process cannot access the file because it is being used by another process.","Response":"'body redacted'"} Client[""].AddCharm

[Martin Packman (gz)]

Have proposed two reverts that will get the tests passing again.

<https://github.com/juju/juju/pull/2207> fixes master by backing out pr2124, and reopened bug 1446871.

<https://github.com/juju/juju/pull/2209> fixes 1.24 by backing out pr2169.

The charm project on github needs sorting out, the head of the v5 branch changed and several revs are now only on v6-unstable.

[Canonical Juju QA Bot (juju-qa-bot)]

Juju-CI verified that this issue is Fix Released in juju-core master:
    http://reports.vapour.ws/releases/2606