api/client: test fails on ppc64le

[Dave Cheney]

This is a ppc64le bug with the go 1.5 port, this does not affect gccgo-4.9/5.0

winton-01(~/src/github.com/juju/juju) % go test ./api/agent
unexpected fault address 0xf8010260f8010280
fatal error: fault
[signal 0xb code=0x1 addr=0xf8010260f8010280 pc=0x1cd1f4]

goroutine 228 [running]:
runtime.throw(0xf45b80, 0x5)
        /home/ubuntu/go/src/runtime/panic.go:543 +0x8c fp=0xc20825d728 sp=0xc20825d710
runtime.sigpanic()
        /home/ubuntu/go/src/runtime/sigpanic_unix.go:27 +0x2f0 fp=0xc20825d778 sp=0xc20825d728
github.com/juju/juju/apiserver/agent.(*AgentAPIV0).StateServingInfo(0x31f470, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/ubuntu/src/github.com/juju/juju/apiserver/agent/agent_v0.go:87 +0x6c fp=0xc20825d870 sp=0xc20825d780
github.com/juju/juju/apiserver/agent.(*AgentAPIV1).StateServingInfo(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        <autogenerated>:22 +0x40 fp=0xc20825d878 sp=0xc20825d870
runtime.call128(0xc2083741e0, 0xe69d38, 0xc208366400)
        /home/ubuntu/go/src/runtime/asm_ppc64x.s:413 +0x88 fp=0xc20825d900 sp=0xc20825d878
reflect.Value.call(0xe69be0, 0xc20802c600, 0x913, 0xf2fee0, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/ubuntu/go/src/reflect/value.go:432 +0xe30 fp=0xc20825dc40 sp=0xc20825d900
reflect.Value.Call(0xe69be0, 0xc20802c600, 0x913, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/ubuntu/go/src/reflect/value.go:300 +0x94 fp=0xc20825dca0 sp=0xc20825dc40
github.com/juju/juju/rpc/rpcreflect.newMethod.func6(0xe69be0, 0xc20802c600, 0x16, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/ubuntu/src/github.com/juju/juju/rpc/rpcreflect/type.go:323 +0xf8 fp=0xc20825dd60 sp=0xc20825dca0
github.com/juju/juju/apiserver.(*srvCaller).Call(0xc20853d000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/ubuntu/src/github.com/juju/juju/apiserver/root.go:131 +0xf0 fp=0xc20825dde8 sp=0xc20825dd60
github.com/juju/juju/rpc.(*Conn).runRequest(0xc208199720, 0x3fff80a4e0c8, 0xc20853d000, 0x1286428, 0x3, 0xc20847c3f0, 0x5, 0x1, 0x0, 0x0, ...)
        /home/ubuntu/src/github.com/juju/juju/rpc/server.go:552 +0x114 fp=0xc20825df28 sp=0xc20825dde8
runtime.goexit()
        /home/ubuntu/go/src/runtime/asm_ppc64x.s:1132 +0x4 fp=0xc20825df28 sp=0xc20825df28
created by github.com/juju/juju/rpc.(*Conn).handleRequest
        /home/ubuntu/src/github.com/juju/juju/rpc/server.go:481 +0x5f4

[Dave Cheney (dave-cheney)]

Being tracked upstream, https://github.com/golang/go/issues/10628

[Curtis Hovey (sinzui)]

I deferred this to 1.26 because ppc is being pushed to Go 1.6.

[Cheryl Jennings (cherylj)]

Is there work needed in juju-core for this bug? I see that the go bug above has been merged, but won't be included in 1.5 (only 1.6)

[Cheryl Jennings (cherylj)]

Dave - is this fixed now that we've gone to go 1.6?

[Dave Cheney (dave-cheney)]

Yes, I believe this is fixed in Go 1.6, and we also worked around it in the code.