Hi Juju Team,
I started to work on debian/copyright file before the official release of 1.23 to decrease the amount of time needed for packaging. I don't expect that the list of dependencies changes seriously from -beta3 to release.
You may see that we have much less issues this cycle which means that we did a very good job last cycle!
(0) [gz:TESTSUITE CLEANER EXPANED TO WIPE NEW LOCATION] [gz:GOLANG BUG FILED]
juju-core_1.23-beta3/src/golang.org/x/net/html/charset/testdata/*.html
Golang guys picked these files from W3C i18n testsuite. At that time this testsuite was licensed under non-modifiable license (LP: #1341589) and we had to manually remove these files from the package. We removed these files from src/code.google.com/p/go.net/ folder but didn't do that for the new src/golang.org/x/net folder. We may want to remove these tests from both locations in the package. See [A] for additional thoughts on this.
(1)
https://github.com/juju/charm/{v4, v5}
License for this project has been changed from AGPLv3 to LGPLv3 with linking exceptions during the previous cycle. Unfortunately virtually all files in the project contain references to AGPLv3 in their headers.
(2)
https://github.com/juju/cmd/blob/master/supercommand_test.go#L2
Header needs to be fixed by changing AGPLv3 to LGPLv3 to conform with the LICENSE file and other files in the project.
(3)
https://github.com/juju/juju/blob/master/apiserver/http/package_test.go
https://github.com/juju/juju/blob/master/wrench/export_test.go
https://github.com/juju/juju/blob/master/utils/logging_test.go
https://github.com/juju/juju/blob/master/utils/logging.go
Headers need to be fixed by changing LGPLv3 to AGPLv3 to conform with the LICENSE file and other files in the project.
(4)
https://github.com/juju/testing/blob/master/stub.go
https://github.com/juju/testing/blob/master/stub_test.go
Headers need to be fixed by changing AGPLv3 to LGPLv3 to conform with the LICENSE file and other files in the project.
=== Minor issues which might be not issues at all ===
(5) [RESOLVED]
https://github.com/juju/juju/blob/master/scripts/win-installer/LICENCE.txt
Do we really need to have AGPLv3 LICENSE file in this folder when we have project-wide AGPLv3 LICENSE file?
This LICENSE file is included into the windows installer.
No change is needed.
(6)
Tarball for juju-1.23-beta3 contains empty folder src/github.com/kisielk/
(7)
Juju-1.23-beta3 has both 'golang.org/x/net' and 'code.google.com/p/go.net/' as dependencies. They look very similar to me maybe even different version of the same code base. I don't know if it's okay or not, just want to make sure that you're aware of it.
Thanks for helping!
[A]
Another way exists as well. W3C now distributes this testsuite under dual-license one of which is BSD (http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html). It means that we can include these tests back to the distribution but only if license file and required copyright notices will be available in the source tree. Golang guys don't have them in the repo and mgz will try to fix this bug upstream. When done, we can return these test back to our package.
I expect this issue will start work in 1.23-beta4 but will really be fixed in a future release of 1.23.