Precise unit test failure discoverySuite.TestDiscoverInitSystemScript

[Curtis Hovey]

Both run-unit-tests-precise-amd64 and run-unit-tests-precise-i386 are failing because of
FAIL: discovery_test.go:333: discoverySuite.TestDiscoverInitSystemScript
FAIL: discoverySuite.TestNewShellSelectCommand

[Curtis Hovey (sinzui)]

----------------------------------------------------------------------
FAIL: discovery_test.go:333: discoverySuite.TestDiscoverInitSystemScript

[LOG] 0:00.056 INFO juju.util.exec run result: exit status 1
[LOG] 0:00.075 DEBUG juju.service discovered init system "upstart" from executable "/sbin/init"
discovery_test.go:347:
    c.Check(response.Code, gc.Equals, 0)
... obtained int = 1
... expected int = 0

discovery_test.go:348:
    c.Check(string(response.Stdout), gc.Equals, initSystem)
... obtained string = ""
... expected string = "upstart"

discovery_test.go:349:
    c.Check(string(response.Stderr), gc.Equals, "")
... obtained string = "/tmp/check-1597969999/1/discover_init_system.sh: line 34: /: Is a directory\n"
... expected string = ""

----------------------------------------------------------------------
FAIL: discovery_test.go:359: discoverySuite.TestNewShellSelectCommand

cat > /tmp/check-1597969999/7/discover_init_system.sh << 'EOF'
#!/usr/bin/env bash

function checkInitSystem() {
    if [[ $1 == *"systemd"* ]]; then
        echo -n systemd
        exit $?
    elif [[ $1 == *"upstart"* ]]; then
        echo -n upstart
        exit $?
    fi
}

# Find the executable.
executable=$(cat /proc/1/cmdline | awk -F"\0" '{print $1}')
if [[ $? -ne 0 ]]; then
    exit 1
fi

# Check the executable.
checkInitSystem "$executable"

# First fall back to following symlinks.
if [[ -L $executable ]]; then
    linked=$(readlink -f "$executable")
    if [[ $? -eq 0 ]]; then
        executable=$linked

        # Check the linked executable.
        checkInitSystem "$linked"
    fi
fi

# Fall back to checking the "version" text.
verText=$("${executable}" --version)
if [[ $? -eq 0 ]]; then
    checkInitSystem "$verText"
fi

# uh-oh
exit 1

EOF
chmod 0755 /tmp/check-1597969999/7/discover_init_system.sh
init_system=$(/tmp/check-1597969999/7/discover_init_system.sh)
if [[ $init_system == "systemd" ]]; then echo -n systemd
elif [[ $init_system == "upstart" ]]; then echo -n upstart
else exit 1
fi
[LOG] 0:00.033 INFO juju.util.exec run result: exit status 1
[LOG] 0:00.037 DEBUG juju.service discovered init system "upstart" from executable "/sbin/init"
discovery_test.go:378:
    c.Check(response.Code, gc.Equals, 0)
... obtained int = 1
... expected int = 0

discovery_test.go:379:
    c.Check(string(response.Stdout), gc.Equals, initSystem)
... obtained string = ""
... expected string = "upstart"

discovery_test.go:380:
    c.Check(string(response.Stderr), gc.Equals, "")
... obtained string = "/tmp/check-1597969999/7/discover_init_system.sh: line 34: /: Is a directory\n"
... expected string = ""

OOPS: 27 passed, 2 FAILED

[Eric Snow (ericsnowcurrently)]

It's odd to me that these tests are not failing on master (from what I can tell). Regardless, I'm looking into it.

[Eric Snow (ericsnowcurrently)]

Apparently older versions of awk cannot handle \0 as a record separator. The alternative is to use the ps command.

[Eric Snow (ericsnowcurrently)]

http://reviews.vapour.ws/r/1204/