Tests require predictable map ordering

[James Tunnicliffe]

In gccgo or newer go versions we can't assume that map ordering is fixed, which results in some new test failures, for example:

dooferlad@homework2:~/juju/service$ go test

----------------------------------------------------------------------
FAIL: service_test.go:49: serviceSuite.TestListServicesCommand

service_test.go:64:
    c.Check(cmd, gc.Equals, strings.Join([]string{
        fmt.Sprintf(line, "/sbin/init", upstart),
        "el" + fmt.Sprintf(line, "/sbin/upstart", upstart),
        "el" + fmt.Sprintf(line, "/sbin/systemd", systemd),
        "el" + fmt.Sprintf(line, "/bin/systemd", systemd),
        "el" + fmt.Sprintf(line, "/lib/systemd/systemd", systemd),
        "else exit 1",
        "fi",
    }, "\n"))
... obtained string = "" +
... "if [[ \"$(cat /proc/1/cmdline)\" == \"/lib/systemd/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/init\" ]]; then sudo initctl list | awk '{print $1}' | sort | uniq\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/upstart\" ]]; then sudo initctl list | awk '{print $1}' | sort | uniq\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/bin/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "else exit 1\n" +
... "fi"
... expected string = "" +
... "if [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/init\" ]]; then sudo initctl list | awk '{print $1}' | sort | uniq\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/upstart\" ]]; then sudo initctl list | awk '{print $1}' | sort | uniq\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/sbin/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/bin/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "elif [[ \"$(cat /proc/1/cmdline)\" == \"/lib/systemd/systemd\" ]]; then /bin/systemctl list-unit-files --no-legend --no-page -t service | grep -o -P '^\\w[\\S]*(?=\\.service)'\n" +
... "else exit 1\n" +
... "fi"

OOPS: 5 passed, 1 FAILED
--- FAIL: TestPackage (0.01s)
FAIL
exit status 1
FAIL github.com/juju/juju/service 0.022s

[Dimiter Naydenov (dimitern)]

Fix proposed with http://reviews.vapour.ws/r/1048/

[Aaron Bentley (abentley)]

Could you please check whether that also fixes https://bugs.launchpad.net/juju-core/+bug/1427454 ?

[James Tunnicliffe (dooferlad)]

Actually I think I have found another instance of this in github.com/juju/juju/apiserver/provisioner. Unfortunately you can't just run all the test once and say you have fixed all the problems - I am doing a lot of repeated testing today!

[James Tunnicliffe (dooferlad)]

@abently yes, this is the same problem and I have fixed that particular failure. I think I have them all now.