ToolsDir should be series based

Bug #1399322 reported by Horacio Durán
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Won't Fix
Low
Unassigned

Bug Description

Recently I had to revert a change in a pr because when using the windows client the tools dir path would generated without separator whatsoever https://github.com/juju/juju/pull/1272 this might be due to the path using windows slashes which where ignored/escaped.

ToolsDir and any other Dir generation should use a target series to decide the path composition (that includes the separator). filepath will just use the separator from the current running code OS which is not right for this case.

My patch only fixes the aforementioned issue, but does not correct the underlying problem where this might be broken for windows workloads since I used path.Join.

Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.22 → 1.23
Curtis Hovey (sinzui)
tags: added: tech-debt
Changed in juju-core:
importance: High → Medium
milestone: 1.23 → none
Curtis Hovey (sinzui)
Changed in juju-core:
importance: Medium → Low
Changed in juju-core:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.