Switch default instance type from m1.small to t2.small/m3.medium for EC2 provider

[Robert C Jennings]

m1.small as the default instance size relies on the previous generation instance type [1]. Amazon is encouraging moving to current generation instance types. t2.small would be comparable to m1.small at half the price or m3.medium would provide consistent performance for a bit more. Either way, my testing is failing because capacity for m1.small is being exhausted.

$ juju charm test -e amazon-charmtest
juju-test INFO : Starting test run on amazon-charmtest using Juju 1.20.7
Launching instance
ERROR bootstrap failed: cannot start bootstrap instance: cannot run instances: We currently do not have sufficient m1.small capacity in the Availability Zone you requested (us-east-1a). Our system will be working on provisioning additional capacity. You can currently get m1.small capacity by not specifying an Availability Zone in your request or choosing us-east-1d, us-east-1b. (InsufficientInstanceCapacity)
Bootstrap failed, destroying environment
ERROR cannot start bootstrap instance: cannot run instances: We currently do not have sufficient m1.small capacity in the Availability Zone you requested (us-east-1a). Our system will be working on provisioning additional capacity. You can currently get m1.small capacity by not specifying an Availability Zone in your request or choosing us-east-1d, us-east-1b. (InsufficientInstanceCapacity)
juju-test.conductor WARNING : Could not bootstrap amazon-charmtest, got Bootstrap returned with an exit > 0. Skipping
Launching instance
ERROR bootstrap failed: cannot start bootstrap instance: cannot run instances: We currently do not have sufficient m1.small capacity in the Availability Zone you requested (us-east-1a). Our system will be working on provisioning additional capacity. You can currently get m1.small capacity by not specifying an Availability Zone in your request or choosing us-east-1d, us-east-1b. (InsufficientInstanceCapacity)
Bootstrap failed, destroying environment
ERROR cannot start bootstrap instance: cannot run instances: We currently do not have sufficient m1.small capacity in the Availability Zone you requested (us-east-1a). Our system will be working on provisioning additional capacity. You can currently get m1.small capacity by not specifying an Availability Zone in your request or choosing us-east-1d, us-east-1b. (InsufficientInstanceCapacity)
juju-test.conductor WARNING : Could not bootstrap amazon-charmtest, got Bootstrap returned with an exit > 0. Skipping
juju-test INFO : Results: 0 passed, 0 failed, 2 errored

[1] https://aws.amazon.com/blogs/aws/aws-update-new-m3-features-reduced-ebs-prices-reduced-s3-prices/

[Kapil Thangavelu (hazmat)]

sigh.. agreed this should be t2.small/m3.medium but the issue on zone avail is separate and not related (and also filed separately).

[Kapil Thangavelu (hazmat)]

actually take that bake a bit, the larger issue with t2.small is that its a hypervisor penalty instance which is poorly suited for a state server.

[Jorge Castro (jorge)]

Just ran into this again, we can prioritize this?

[Jorge Castro (jorge)]

Also AWS has recommended m3's for all new workloads: https://aws.amazon.com/blogs/aws/ec2-update-previous-generation-instances/

They've also dropped all the m1's from their web console.

[Ben Howard (utlemming)]

Raising this to critical. IMHO, this is going to be a substantial problem for our users as they will hit capacity constraints as the availability of m1.x family becomes limited. Further, users are going to hit issues with performance since the newer instance types are more performant and cheaper.

[Nate Finch (natefinch)]

Working on this now.

[Nate Finch (natefinch)]

For reference, I'm going to set the default to m3.medium... if you don't like that choice, speak now or forever hold your peace.

[Katherine Cox-Buday (cox-katherine-e)]

1.25 review request is here: http://reviews.vapour.ws/r/2720/

[Katherine Cox-Buday (cox-katherine-e)]

The fix is causing some unexpected test failures. More investigation is needed, so we're pushing to beta2 for 1.25.