juju-core client panics with juju set empty string

[Simon Davy]

Juju 1.20.1.1 from stable ppa, trusty amd64

$ juju deploy postgresql
$ juju set postgresql fsync=
panic: runtime error: index out of range

goroutine 1 [running]:
runtime.panic(0xcc1300, 0x19ec9b7)
        /usr/lib/go/src/pkg/runtime/panic.c:266 +0xb6
main.(*SetCommand).Run(0xc21011ad00, 0xc2100dd0f0, 0x0, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/set.go:92 +0x62d
github.com/juju/juju/cmd/envcmd.(*environCommandWrapper).Run(0xc21011bee0, 0xc2100dd0f0, 0xb27740, 0xc21012d430)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/envcmd/environmentcommand.go:1 +0x3d
main.(*envCmdWrapper).Run(0xc21011bf00, 0xc2100dd0f0, 0x0, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/addmachine.go:1 +0x3d
github.com/juju/cmd.(*SuperCommand).Run(0xc2100fc2c0, 0xc2100dd0f0, 0xc2100dd0f0, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/cmd/supercommand.go:321 +0x3ca
github.com/juju/cmd.Main(0x7f975c2863c0, 0xc2100fc2c0, 0xc2100dd0f0, 0xc21000a010, 0x3, ...)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/cmd/cmd.go:247 +0x283
main.Main(0xc21000a000, 0x4, 0x4)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/main.go:77 +0xada
main.main()
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/main.go:174 +0x44

goroutine 3 [syscall]:
os/signal.loop()
        /usr/lib/go/src/pkg/os/signal/signal_unix.go:21 +0x1e
created by os/signal.init·1
        /usr/lib/go/src/pkg/os/signal/signal_unix.go:27 +0x31

goroutine 12 [syscall]:
runtime.goexit()
        /usr/lib/go/src/pkg/runtime/proc.c:1394
$ juju set postgresql fsync
error: invalid option: "fsync"

This was fixed in 1.15 I think (https://bugs.launchpad.net/juju-core/+bug/1194945), so looks like a regression.

[Matt Bruzek (mbruzek)]

I am also seeing this problem with Juju 1.20.1-trusty-amd64 on local provider.

mbruzek@workhorse:~/workspace/charms/precise/nfs$ juju set nfs storage_root=
panic: runtime error: index out of range

goroutine 1 [running]:
runtime.panic(0xcc1300, 0x19ec9b7)
        /usr/lib/go/src/pkg/runtime/panic.c:266 +0xb6
main.(*SetCommand).Run(0xc210142180, 0xc2100e0000, 0x0, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/set.go:92 +0x62d
github.com/juju/juju/cmd/envcmd.(*environCommandWrapper).Run(0xc210141c80, 0xc2100e0000, 0xb27740, 0xc210151410)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/envcmd/environmentcommand.go:1 +0x3d
main.(*envCmdWrapper).Run(0xc210141ca0, 0xc2100e0000, 0x0, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/addmachine.go:1 +0x3d
github.com/juju/cmd.(*SuperCommand).Run(0xc210121580, 0xc2100e0000, 0xc2100e0000, 0x0)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/cmd/supercommand.go:321 +0x3ca
github.com/juju/cmd.Main(0x7f84c73a11f0, 0xc210121580, 0xc2100e0000, 0xc21000a010, 0x3, ...)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/cmd/cmd.go:247 +0x283
main.Main(0xc21000a000, 0x4, 0x4)
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/main.go:77 +0xada
main.main()
        /build/buildd/juju-core-1.20.1/src/github.com/juju/juju/cmd/juju/main.go:174 +0x44

goroutine 3 [syscall]:
os/signal.loop()
        /usr/lib/go/src/pkg/os/signal/signal_unix.go:21 +0x1e
created by os/signal.init·1
        /usr/lib/go/src/pkg/os/signal/signal_unix.go:27 +0x31

goroutine 12 [syscall]:
runtime.goexit()
        /usr/lib/go/src/pkg/runtime/proc.c:1394

[Andreas Hasenack (ahasenack)]

Still happens with 1.20.5

juju set someservicedoesntmatter somevalue=
panic: runtime error: index out of range
(...)

[Jorge Niedbalski (niedbalski)]

Fixed on https://github.com/juju/juju/pull/668/files

[Ian Booth (wallyworld)]

Setting back to In progress because PR hasn't merged yet