MustErr on API server is unsafe

Bug #1334390 reported by Bodie Solomon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Won't Fix
Medium
Unassigned

Bug Description

Per @fwereade [1] MustErr is not safe and should never be used outside of client code.

...

   StringsWatcherId: u.resources.Register(watch),
   Changes: changes,
  }, nil
 }
 return nothing, watcher.MustErr(watch)
}

1. https://github.com/juju/juju/pull/141#discussion_r14180067

Tags: api tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → Medium
tags: added: tech-debt
tags: added: api
Revision history for this message
Bodie Solomon (binary132) wrote :

Edited title to be more correct: MustErr on apiserver is the issue.

summary: - MustErr on client API is unsafe
+ MustErr on API server is unsafe
Changed in juju-core:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.