worker/peergrouper: test failure
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Dave Cheney |
Bug Description
Replica sets are, well, sets, not lists. The tests should use jc.SameContent
[LOG] 0:00.003 INFO juju.worker.
worker_test.go:382:
c.Assert(
... obtained []instance.Id = []instance.
... expected []instance.Id = []instance.
... mismatch at [0]: unequal; obtained "id-12"; expected "id-10"
[LOG] 0:00.010 ERROR juju.worker.
OOPS: 9 passed, 2 FAILED
--- FAIL: TestPackage (1.14 seconds)
FAIL
FAIL launchpad.
Related branches
- Juju Engineering: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedworker/peergrouper/worker_test.go (+1/-1)
- Juju Engineering: Pending requested
-
Diff: 94 lines (+30/-12)1 file modifiedworker/peergrouper/mock_test.go (+30/-12)
- Juju Engineering: Pending requested
-
Diff: 76 lines (+33/-4)2 files modifiedworker/peergrouper/desired_test.go (+29/-0)
worker/peergrouper/worker_test.go (+4/-4)
Changed in juju-core: | |
milestone: | 1.18.0 → changelog.txt |
status: | Triaged → In Progress |
milestone: | changelog.txt → 1.18.0 |
Changed in juju-core: | |
milestone: | 1.19.0 → 2.0 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
milestone: | 2.0 → 1.19.0 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
worker_test.go:350: servers, jc.DeepEquals, expectedAPIHost Ports(3) ) HostPort = [][]instance. HostPort{ []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.11" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}, []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.12" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}, []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.10" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}} HostPort = [][]instance. HostPort{ []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.10" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}, []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.11" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}, []instance. HostPort{ instance. HostPort{ Address: instance. Address{ Value:" 0.1.2.12" , Type:"ipv4", NetworkName:"", NetworkScope:""}, Port:5678}}} Address. Value: unequal; obtained "0.1.2.11"; expected "0.1.2.10"
c.Assert(
... obtained [][]instance.
... expected [][]instance.
... mismatch at [0][0].
[LOG] 0:00.023 ERROR juju.worker. peergrouper peergrouper loop terminated: tomb: dying