we should set GOMAXPROCS to NumCPU in the API Server

Bug #1290841 reported by John A Meinel on 2014-03-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
High
John A Meinel

Bug Description

The API Server will be single threaded (and thus very CPU bound) if we don't set GOMAXPROCS to NumCPU
We probably want to only enable it for agents that are running the API server, because the other agents aren't ever CPU bound, and thus it helps avoid worrying about race conditions.

We also probably don't want to enable it during the test suite, because of problems we've seen with concurrent testing breaking test isolation (Bug #1199437), but it shouldn't be too hard to just enable the ability to turn on GOMAXPROCS in main() and then use that functionality when we determine we are an API server.

Related branches

John A Meinel (jameinel) wrote :

I have a patch for it, this is about finishing off the patch so it is correct for testing, and landing it.

John A Meinel (jameinel) on 2014-03-20
Changed in juju-core:
milestone: none → 1.17.6
status: Triaged → In Progress
Go Bot (go-bot) on 2014-03-20
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui) on 2014-03-20
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers