Juju should NOT put a .git directory in $CHARM_DIR

Bug #1281583 reported by Marco Ceppi
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Low
William Reade

Bug Description

While trying to model various methods of managing and pushing charms, having juju track it's internal changes to files during events using git with the git repo (.git dir) in $CHARM_DIR breaks for git based charms. Instead git init should be called with `--separate-git-dir`[0] and placed somewhere like /var/lib/juju/agents/unit-*/charm.git. All other commands should be run with `--git-dir`[1] pointing to ../charm.git - in doing so this will allow for better CI/CD of charms given that the state of the charm is tracked outside of the charm.

[0]: http://git-scm.com/docs/git-init
[1]: http://git-scm.com/2010/04/11/environment.html

Marco Ceppi (marcoceppi)
description: updated
Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → Low
tags: added: charms feature git
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 1281583] Re: Juju should NOT put a .git directory in $CHARM_DIR

We're removing using git to track the charm content (William is poking at
that.) I'm pretty sure it is being tracked in a different bug.

John
=:->
On Feb 18, 2014 3:20 PM, "Curtis Hovey" <email address hidden> wrote:

> ** Changed in: juju-core
> Status: New => Triaged
>
> ** Changed in: juju-core
> Importance: Undecided => Low
>
> ** Tags added: charms feature git
>
> --
> You received this bug notification because you are subscribed to juju-
> core.
> https://bugs.launchpad.net/bugs/1281583
>
> Title:
> Juju should NOT put a .git directory in $CHARM_DIR
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1281583/+subscriptions
>

Revision history for this message
William Reade (fwereade) wrote :

Resolved by fix for lp:1232304 -- new deployments will not create a .git dir, and old deployments will be converted to no longer use git. Old deployments *will* keep the pre-existing .git dir in place until it can be safely removed -- next charm upgrade -- but you can manually remove it ahead of time if you need to.

Changed in juju-core:
milestone: none → 1.19.1
assignee: nobody → William Reade (fwereade)
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.