juju status incompatible in 1.17.0 against 1.16
Bug #1266734 reported by
John A Meinel
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Martin Packman |
Bug Description
Doing:
$ sudo apt-get install juju-core=
$ sudo /usr/bin/juju bootstrap -e local
$ juju --version
1.17.1-
$ juju status -e local
environment: ""
machines:
"0":
instance-id: localhost
services: {}
What would be expected is more:
$ /usr/bin/juju status -e local
environment: local
machines:
"0":
agent-state: started
agent-version: 1.16.5.1
dns-name: 10.0.3.1
instance-id: localhost
series: precise
services: {}
could be considered part of bug #1253619
Related branches
lp:~gz/juju-core/status_api_1.16_compat
- Juju Engineering: Pending requested
-
Diff: 139 lines (+102/-6)3 files modifiedstate/api/client.go (+25/-5)
state/apiserver/client/status.go (+19/-1)
state/apiserver/client/status_test.go (+58/-0)
Changed in juju-core: | |
milestone: | 1.17.1 → 1.18.0 |
tags: | added: regression |
Changed in juju-core: | |
status: | Triaged → Fix Committed |
Changed in juju-core: | |
milestone: | 1.18.0 → 1.17.4 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The issue is that there *was* a Client.Status API in 1.16, so 1.17 isn't triggering its fallback code, it, instead, is just using what 1.16 returned.
So we accidentally broke the API Client.Status (because nothing else was using it we didn't notice).
So we should restore the 1.16 functionality (Deprecated, but we shouldn't be changing it) and introduce new functionality in a different name (or finally implement API versioning)