drop tools upload capability

Bug #1262175 reported by William Reade
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
juju-core
Won't Fix
Low
Unassigned

Bug Description

The uplod tools functionality, used by bootstrap and upgrade-juju, is evil and damaging partly because it's a developer hack that allows us to avoid the most common tools-location code paths, and partly because it also special-cases finding and magically distributing a local jujud binary with a faked-up version number; and this is really awful because people have discovered this and started using it.

We need to (1) drop --upload-tools across the board and (2) come up with sane mechanisms for distributing local copies of jujud tools; consider that we already have:

* the --source arg that already exists, but isn't used by upgrade-juju
* the tools[-metadata]-url in the environment config

...and the ability, with synchronous bootstrap, to put tools directly on the state server as we bootstrap.

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

i came across this bug while, i was about to file a bug to enable --upload-tools usage. The lookup for tools is rather complex and error prone and hard to debug for private clouds. (i had had wallyword and mgz helping a partner for over 2hrs on irc the other day). upload-tools is both simple and effective, i'd rather have a safety valve then mandate complexity, ideally allowing it even in the absence of compilation tools.

Curtis Hovey (sinzui)
tags: added: upload-tools
Revision history for this message
Ian Booth (wallyworld) wrote :

Actually, it wasn't tools lookup that took the time when helping the partner. It was image id lookup that was causing issues, and also a ssh hostname verification bug. The image id lookup was problematic because the cloud instances were running on a network without the ability to provide http access to the swift containers. A solution for this is landing now. There's also a solution for the hostname verification issue in progress.

So regardless of the merits of --upload-tools, the recent customer support issue should not come into it.

Martin Packman (gz)
Changed in juju-core:
milestone: 1.17.1 → 1.18.0
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

fair enough re image metadata issue.. to me the reality is tools lookup is fairly complex, not in our docs, hoses people regulary in private clouds... and something that developers rarely use. the flipside is --upload-tools is dirt simple.. use the binary i'm running right now. to me the reality is for production environments, doing a simple streams lookup (with no dry run..) is frought with mystery.. the simplicity of use the binary i'm running right now is a huge win for prod environments.

summary: - drop --upload-tools flag
+ debate drop --upload-tools flag
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Re: debate drop --upload-tools flag

Getting away with upload-tools without having a nice and simple story for tools is wrong. As kapil says, setting up tools in a private cloud is difficult, much more difficult than using --upload-tools.

Changed in juju-core:
milestone: 1.20.0 → next-stable
Revision history for this message
Curtis Hovey (sinzui) wrote :

As we promise to maintain compatability with 1.18.x for the life of 1.x, I don't think this issue is still important. We will live with the feature until we choose to create 2.0-alpha1

Changed in juju-core:
milestone: next-stable → none
importance: High → Low
Curtis Hovey (sinzui)
tags: added: juju-qa
Seman (sseman)
tags: added: jujuqa
Revision history for this message
Cheryl Jennings (cherylj) wrote :

In 2.0 discussions, it was decided that for 2.0, we will disallow upgrades to hosted models using --upload-tools. See bug #1567170

Curtis Hovey (sinzui)
tags: removed: juju-qa
tags: added: simplestreams
Ian Booth (wallyworld)
summary: - debate drop --upload-tools flag
+ debate drop tools upload capability
description: updated
summary: - debate drop tools upload capability
+ drop tools upload capability
Changed in juju-core:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.