cloudinit/sshinit is dependent on cloud-init implementation details
Bug #1259942 reported by
Andrew Wilkins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
High
|
Andrew Wilkins | ||
Bug Description
sshinit.Configure waits in a loop while there are any processes whose names match "cloud-init". This both makes sshinit dependent on cloud-init's implementation details, and also introduces a fragility in manual bootstrap where anyone running a process matching "cloud-init" will stall Juju.
We should change sshinit to synchronise with cloud-init using something within our control, for example by waiting for the presence of a file on disk.
Related branches
lp:~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2
- Juju Engineering: Pending requested
-
Diff: 1303 lines (+486/-171)26 files modifiedcloudinit/cloudinit_test.go (+1/-1)
cloudinit/options.go (+1/-1)
cloudinit/sshinit/configure.go (+0/-11)
cmd/jujud/machine_test.go (+1/-1)
container/kvm/instance.go (+4/-0)
container/lxc/instance.go (+4/-0)
container/lxc/lxc_test.go (+1/-1)
environs/cloudinit/cloudinit.go (+17/-0)
environs/cloudinit/cloudinit_test.go (+7/-3)
environs/cloudinit_test.go (+5/-1)
instance/instance.go (+3/-0)
provider/azure/instance.go (+7/-0)
provider/common/bootstrap.go (+209/-59)
provider/common/bootstrap_test.go (+95/-37)
provider/common/export_test.go (+1/-0)
provider/dummy/environs.go (+4/-0)
provider/ec2/ec2.go (+37/-17)
provider/ec2/local_test.go (+4/-0)
provider/joyent/instance.go (+4/-0)
provider/local/instance.go (+4/-0)
provider/maas/environ.go (+1/-1)
provider/maas/environ_whitebox_test.go (+2/-2)
provider/maas/instance.go (+22/-7)
provider/maas/instance_test.go (+10/-10)
provider/null/instance.go (+15/-11)
provider/openstack/provider.go (+27/-8)
| Changed in juju-core: | |
| assignee: | nobody → Andrew Wilkins (axwalk) |
| status: | Triaged → Won't Fix |
| status: | Won't Fix → In Progress |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| importance: | Medium → High |
| milestone: | none → 1.17.0 |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
