ssh timeout for bootstrap could be configurable
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
Critical
|
Dimiter Naydenov |
Bug Description
We're working on making 'juju bootstrap' try to connect to the machine that it is starting up. As part of this we have stuff like "how long should we wait before we decide that instance is not going to come up."
Right now we just use a fixed 10min timeout + 5s retry delay. It seems like something that people might actually like to be able to configure in there environments.yaml. As it should be client <=> cloud specific. (This cloud takes longer to start up, this one is known to fail if it hasn't started in 10s, etc)
It might also be a good fit for how we connect to the API. Although with synchronous bootstrap, we should probably be less likely to wait for the API to come up. (If you can't run anything until that machine is up, then you should never have to wait very long on every other command.)
At the very least, timeouts are rarely a "one size fits all" so allowing them to be configurable can be useful.
Related branches
- Dimiter Naydenov (community): Approve
-
Diff: 401 lines (+187/-54)5 files modifiedcmd/juju/bootstrap.go (+10/-1)
environs/config/config.go (+78/-15)
environs/config/config_test.go (+86/-3)
provider/common/bootstrap.go (+11/-33)
provider/common/bootstrap_test.go (+2/-2)
Changed in juju-core: | |
importance: | Wishlist → Low |
Changed in juju-core: | |
milestone: | 1.17.1 → 1.18.0 |
Changed in juju-core: | |
importance: | High → Critical |
Changed in juju-core: | |
assignee: | nobody → Dimiter Naydenov (dimitern) |
Changed in juju-core: | |
status: | Triaged → In Progress |
Changed in juju-core: | |
milestone: | 1.18.0 → 2.0 |
milestone: | 2.0 → 1.18.0 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
milestone: | 1.18.0 → 1.17.2 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
I think this is irrelevant now that https:/ /code.launchpad .net/~axwalk/ juju-core/ waitssh- no-conn- timeout/ +merge/ 198658 is merged in. Can we close this?