juju-core

state: unit assignment emptiness check is not transactional

Bug #1253704 reported by Roger Peppe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Low
Unassigned

Bug Description

Unit.assignToCleanMaybeEmptyMachine selects only machines without containers
when requireEmpty is true, but it does not do that in a transactional
way and it does not assert that a machine so chosen is still empty when
the unit is actually assigned.

I think Unit.assignToMachine should contain an optional assertion to that
effect.

Tags: tech-debt
Roger Peppe (rogpeppe)
Changed in juju-core:
importance: Undecided → Medium
status: New → Confirmed
Curtis Hovey (sinzui)
Changed in juju-core:
importance: Medium → Low
status: Confirmed → Triaged
Anastasia (anastasia-macmood)
Changed in juju-core:
status: Triaged → Won't Fix
Revision history for this message
Roger Peppe (rogpeppe) wrote :

Is this actually fixed in fact? If so, then perhaps mark as "Fix released". If not then it's still a potential bug where you might get results that are not consistent with requirements.

Revision history for this message
Anastasia (anastasia-macmood) wrote :

This has been fixed in Juju 2. For any further failures, please file new bugs against "juju" :D

Changed in juju-core:
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.