lxc containers broken with maas

[Tim Penhey]

[Impact]
LXC containers under the MAAS provider never startup

[Test Case]
configure a maas environment
juju bootstrap
juju add-machine lxc:0
(machine appears in status output but never starts).

[Regression Potential]
Restructuring of the way cloud-init data is constructed and the new API call to allow the correct secrets to be retrieved as potentially wide impact.

[Original Bug Report]
Machines are shown as pending and never start.

There is an error parsing the config returned from the API call.
   ERROR juju.worker environ.go:50 loaded invalid environment configuration: malformed maas-oauth (3 items separated by colons)

maas-oauth is listed as a secret. Although I have not fully investigated yet, I believe that this is a regression that was introduced when the provisioner task was moved to the API, and the environment config is also returned over the API. I posit that the secrets are removed from the environment config before returning them over the API. This makes the configuration invalid, so the "wait for a valid config" just hangs, and the provider fails to enter the main loop.

[Tim Penhey (thumper)]

There is the correct fix, and there is the quick fix.

The quick fix is likely to be an indicator in the config that this config is passed over the api, so tempter the validation as such.

The correct fix is to change the provisioner so it doesn't need the full environ config, but instead just asks for what it actually needs, which is likely to be the authorized keys.

[Tim Penhey (thumper)]

Progress report: I have now found two ways not to do it.

I think the correct approach here is to add an api end point to get the authorized keys, and then modify all the call sites.

[Launchpad Janitor (janitor)]

This bug was fixed in the package juju-core - 1.16.2-0ubuntu1

---------------
juju-core (1.16.2-0ubuntu1) trusty; urgency=low

  * New upstream point release.
    (LP: #1240709, #1240927, #1246320, #1246556, #1245004)
    (LP: #1081247, #1229275, #1239508, #1240423, #1241666, #1243861).
 -- James Page <email address hidden> Thu, 31 Oct 2013 21:22:45 +0000

[Brian Murray (brian-murray)]

Hello Tim, or anyone else affected,

Accepted juju-core into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/juju-core/1.16.3-0ubuntu0.13.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[James Page (james-page)]

Confirmed able to add LXC containers to physical servers using this update.

[Launchpad Janitor (janitor)]

This bug was fixed in the package juju-core - 1.16.3-0ubuntu0.13.10.1

---------------
juju-core (1.16.3-0ubuntu0.13.10.1) saucy-proposed; urgency=low

  * New upstream stable point release:
    - MAAS: juju destroy-environment also destroys nodes that are not
      controlled by juju/in different juju environments
      (LP: #1229275, #1081247).
    - MAAS: LXC container provisioning broken due to missing secrets
      in API calls (LP: #1246556).
    - MAAS: disambiguate use of environment uuid between state server
      and environment configuration (LP: #1240423).
    - local: provider fails to start due to missing setup of bootstrap
      storage (LP: #1240709).
    - local: local provider deploys fail due to inclusion of lxc package
      within LXC containers (LP: #1247299).
    - Azure: bootstrap fails due to old API version headers (LP: #1246320).
    - client: os.rename does not work on Windows (LP: #1240927).
    - simplestreams: cannot create simplestreams data for Ubuntu Trusty
      (LP: #1241666).
    - cloud-init: Embed full cloud-archive keyring in metadata to avoid
      calls to keyserver.ubuntu.com which fail in egress restricted
      data center environments (LP: #1243861).
    - core: regression - relation name regex is to restrictive (LP: #1245004).
 -- James Page <email address hidden> Thu, 21 Nov 2013 10:30:39 +0000

[Stéphane Graber (stgraber)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.