constraints should be validated
Bug #1237626 reported by
Kapil Thangavelu
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Ian Booth |
Bug Description
Generic constraints map to an instance type, an unsolved instance type should result in an error at deploy/constraint set time. This problem only increases as we get to parity around constraints (instance-type, zone, etc). In all of these cases the provider vocabulary for the constraint is either introspectable or static in the code, and should be validated against the provider vocabulary when the constraint is set rather than resulting in a pending forever instance. In some cases constraints are dynamic so the async feedback mechanism (status collection) will need to be utilized for runtime provider vocabulary changes.
Related branches
lp:~wallyworld/juju-core/constraints-vocab
- Juju Engineering: Pending requested
-
Diff: 891 lines (+388/-89)24 files modifiedcmd/juju/bootstrap.go (+4/-1)
constraints/constraints.go (+7/-14)
constraints/constraints_test.go (+44/-18)
constraints/export_test.go (+1/-1)
constraints/validation.go (+98/-8)
constraints/validation_test.go (+46/-0)
environs/interface.go (+1/-1)
environs/statepolicy.go (+1/-1)
provider/azure/environ.go (+12/-2)
provider/azure/environ_test.go (+17/-4)
provider/dummy/environs.go (+2/-2)
provider/ec2/ec2.go (+12/-2)
provider/ec2/local_test.go (+19/-5)
provider/joyent/environ_instance.go (+16/-2)
provider/joyent/local_test.go (+14/-1)
provider/local/environ.go (+7/-2)
provider/local/environ_test.go (+22/-2)
provider/maas/environ.go (+7/-2)
provider/maas/environ_test.go (+0/-12)
provider/maas/environ_whitebox_test.go (+19/-0)
provider/manual/environ.go (+2/-2)
provider/manual/environ_test.go (+2/-1)
provider/openstack/local_test.go (+18/-4)
provider/openstack/provider.go (+17/-2)
affects: | juju → juju-core |
Changed in juju-core: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: constraints tech-debt |
Changed in juju-core: | |
assignee: | nobody → Ian Booth (wallyworld) |
importance: | Low → High |
milestone: | none → 1.20.0 |
Changed in juju-core: | |
status: | Triaged → In Progress |
Changed in juju-core: | |
milestone: | 1.20.0 → 1.19.1 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.