destroy-env on openstack should remove sec groups
Bug #1227574 reported by
Kapil Thangavelu
This bug affects 9 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
High
|
Abel Deuring | ||
Bug Description
Destroy environment should clean up security groups. The openstack api let's one manipulate groups at runtime unlike the ec2 api (which wants the instances to be terminated before allowing removal of group). There's no reason we should be leaving these behind, especially given the relatively low count of security groups an openstack provider allows.
Related branches
lp:~adeuring/juju-core/1227574
- Abel Deuring (community): Approve
-
Diff: 219 lines (+167/-2)2 files modifiedprovider/openstack/local_test.go (+105/-0)
provider/openstack/provider.go (+62/-2)
| description: | updated |
Revision history for this message
| John A Meinel (jameinel) wrote | #1 |
| Changed in juju-core: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: destroy-environment security |
| tags: | added: canonical-webops destroy-machine |
Revision history for this message
| Marco Ceppi (marcoceppi) wrote | #2 |
| tags: | added: canonical-is |
| tags: | added: charmers ci |
| Changed in juju-core: | |
| milestone: | none → 1.19.0 |
| assignee: | nobody → Abel Deuring (adeuring) |
| status: | Triaged → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
as noted in the duplicate, this also interacts poorly with bug #1217595 and bug #1226996 in that if security groups are left around, we just use them as they were. Though I would focus on fixing bug #1217595 before this one.