environs/simplestreams/simplestreams.go leaks test:// and file:// URLs into the http.DefaultClient

[John A Meinel]

I believe the code was written such that it wanted to isolate stuff like RegisterProtocol("file") and RegisterProtocol("test") into just the simplestreams httpClient object.

However, it uses the http.DefaultTransport which means when you register a new transport you are mutating the global net/http library state.

I'll link a branch that shows this.

At runtime, it has the property that any net/http.* request will be able to access file:// URLs. In the test suite, it means that we expose test:// URLs as well as file:// URLs to all tests.

[Anastasia (anastasia-macmood)]

Re-targeting to Juju 2.x

[Anastasia (anastasia-macmood)]

As this is a tech-debt item, I am lowering its Importance.

[Canonical Juju QA Bot (juju-qa-bot)]

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.