Using the same maas user in different juju environments causes them to clash

Bug #1222671 reported by Dave Cheney
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Go MAAS API Library
Fix Released
High
Unassigned
juju-core
Fix Released
High
Tim Penhey
1.16
Fix Released
High
Curtis Hovey

Bug Description

If many juju environments use the same maas user, they will clash and be effectively the same environment since juju will see the same provider state across all environments.

(This bug used to be about destroying environments but this is a more generalised description now)

MAAS task removed as it is tracked in bug 1239488

Revision history for this message
Julian Edwards (julian-edwards) wrote :

To clarify, it lists nodes that the user owns, but not all of the nodes he owns may be in an "allocated" state (this may or may not be a bug in maas). The code should check the owned nodes and further filter by "allocated" state.

summary: - maas provider must only attempt to stop machines it owns
+ maas provider must only attempt to stop machines in the allocated state
William Reade (fwereade)
Changed in gomaasapi:
status: New → Triaged
importance: Undecided → High
Chris J Arges (arges)
tags: added: cts-cloud-review
Tim Penhey (thumper)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
John A Meinel (jameinel)
Changed in juju-core:
assignee: nobody → Tim Penhey (thumper)
Tim Penhey (thumper)
tags: added: maas
Tim Penhey (thumper)
Changed in juju-core:
milestone: none → 2.0
Mark Ramm (mark-ramm)
Changed in juju-core:
milestone: 2.0 → 1.17.0
Curtis Hovey (sinzui)
tags: added: cts
removed: cts-cloud-review
Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: maas provider must only attempt to stop machines in the allocated state

This is most likely to be someone re-using credentials or the same maas user across different juju environments. I'm going to change the bug title.

summary: - maas provider must only attempt to stop machines in the allocated state
+ Using the same maas user in different juju environments causes them to
+ clash
description: updated
Roger Peppe (rogpeppe)
Changed in gomaasapi:
status: Triaged → Fix Committed
Changed in juju-core:
status: Triaged → Fix Committed
Tim Penhey (thumper)
no longer affects: maas
description: updated
Revision history for this message
Antonio Rosales (arosales) wrote :

Note, to fully resolve this bug a Juju user will also need the fix from MAAS bug 1239488 (noted in the description).

-thanks,
Antonio

Curtis Hovey (sinzui)
tags: added: cts-cloud-review
removed: cts
Curtis Hovey (sinzui)
tags: added: maas-provider
removed: maas
Revision history for this message
Curtis Hovey (sinzui) wrote :

At this moment, there are no branches linked to this bug to indicate why it is fixed. I can see that Tim did not land anything related this bug in the days preceding the change to Fix Committed. I do believe this bug is fixed and that it is probably Fix Released in juju 1.16.2.

The Maas aspect of this bug is is Fix Released in Bug #1239488 (the maas task was removed from this bug). Bug #1229275 was also fixed about this time over several commits. Bug #1240423 was the last of this set of maas bugs to be fixed. I think this bugs remaining topic overlapped with the other maas bugs. Roger merged all the revisions that fixed Bug #1229275 and Bug #1240423 into lp:juju-core/1.16 with https://code.launchpad.net/~rogpeppe/juju-core/454-1.16-maas-changes/+merge/191413 . I believe Roger marked this bug as Fix Committed in 1.17 because it is implicitly fixed.

If this bug is not Fix Released in 1.16, then the likely reason is that 4 fixes to gomaasapi that are used by juju-core trunk that are not used by 1.16. The fixes are api-compatible; I have verified all unit tests pass under 1.16.4 with gomaasapi r47 (lp:~sinzui/juju-core/update-1.16-gomaasapi).

Revision history for this message
Curtis Hovey (sinzui) wrote :

We believe this issue was fixed in juju-core 1.16.2 based on the merges that were included in the release tarball.

Curtis Hovey (sinzui)
Changed in gomaasapi:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.