differing behavior with pyjuju: config-get all json
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Frank Mueller |
Bug Description
PY JUJU:
config-get all: {"log-level": "DEBUG"}
JUJU-CORE:
config-get all: {"account-
juju-core returns all items even if not set. I'm not sure if this change was intended. I can't really see much value for it, and it does require at least us to change our charm to account for this modification (maybe other teams and individuals would need to do the same). If this is easily fixable in core, it might make sense to do it.
Querying individual values through config-get behaves the same in both juju core and pyjuju. I'll attach a full log showing both outputs.
Related branches
- William Reade (community): Approve
-
Diff: 250 lines (+119/-11)3 files modifiedworker/uniter/jujuc/config-get.go (+22/-1)
worker/uniter/jujuc/config-get_test.go (+92/-10)
worker/uniter/jujuc/util_test.go (+5/-0)
Changed in juju-core: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Frank Mueller (themue) |
Changed in juju-core: | |
status: | Confirmed → In Progress |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
milestone: | none → 1.11.1 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
Full output if interested on what happens when you query unset configs in different ways.
PY JUJU:
2013-06-19 21:56:35,411: hook.output@INFO: all: {"log-level": "DEBUG"}
data-path:
data-path(json): null
JUJU-CORE:
2013-06-19 22:08:57 INFO juju context.go:221 worker/uniter: HOOK all: {"account- name":null, "autodiscover- a-query- string" :null," autodiscover- srv-query- string" :null," data-path" :null," exchange- interval" :null," http-proxy" :null," https-proxy" :null," include- manager- plugins" :null," log-dir" :null," log-level" :"DEBUG" ,"origin" :null," ping-interval" :null," ping-url" :null," registration- key":null, "script- users": null,"server- autodiscover" :null," ssl-public- key":null, "tags": null,"urgent- exchange- interval" :null," url":null}
2013-06-19 22:08:57 INFO juju context.go:221 worker/uniter: HOOK data-path:
2013-06-19 22:08:57 INFO juju context.go:221 worker/uniter: HOOK data-path(json): null