unit agent fails after a few upgrades

[William Reade]

juju-lcy2-machine-16:2013/06/13 13:02:04 NOTICE worker/uniter: unit "postgresql/0" shutting down: ModeUpgrading local:precise/postgresql-42: failed to create "/var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9": mkdir /var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9: file exists
juju-lcy2-machine-16:2013/06/13 13:02:04 ERROR worker/uniter/filter: tomb: dying
juju-lcy2-machine-16:2013/06/13 13:02:04 ERROR uniter for postgresql/0: ModeUpgrading local:precise/postgresql-42: failed to create "/var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9": mkdir /var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9: file exists
juju-lcy2-machine-16:2013/06/13 13:02:04 ERROR ModeUpgrading local:precise/postgresql-42: failed to create "/var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9": mkdir /var/lib/juju/agents/unit-postgresql-0/state/deployer/update-%Y%m%d-%H%M%S-9: file exists

er, looks like we're not formatting a format string there :/.

[John A Meinel (jameinel)]

We're using time.Format wrong: http://play.golang.org/p/1C5k3aFKmI

The only question IMO is whether we should be using time.Now at all, instead of ioutil.TempDir which is designed to handle collisions like this.

[John A Meinel (jameinel)]

Ah, I read the duplication wrong, this is marked as a dupe of that.