service set config needs to have more logic inside the state package
Bug #1130618 reported by
Roger Peppe
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
Medium
|
William Reade |
Bug Description
Currently it validates the options against the service's current charm, but
that might change while it's doing it.
Related branches
lp:~fwereade/juju-core/config-5-state-service-config-yaml
- Juju Engineering: Pending requested
-
Diff: 340 lines (+105/-53)7 files modifiedcmd/juju/config_test.go (+6/-7)
juju/conn_test.go (+9/-3)
state/apiserver/client_test.go (+5/-7)
state/apiserver/perm_test.go (+2/-2)
state/service.go (+40/-27)
state/service_test.go (+19/-5)
state/statecmd/deploy_test.go (+24/-2)
Changed in juju-core: | |
status: | New → In Progress |
assignee: | nobody → William Reade (fwereade) |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
milestone: | none → 1.11.1 |
Changed in juju-core: | |
importance: | Undecided → Medium |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
see also https:/ /codereview. appspot. com/7326052/ diff/1001/ state/statecmd/ config. go#newcode53