bootstrap needs environment config
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
Undecided
|
Dave Cheney |
Bug Description
As it is, initzk takes --instance-id and --env-type (in addition to state info). This is not enough information; while we *could* infer both authorized-keys and default-series from local state on the bootstrap machine, we still don't have the environment name; and we *will* need constraints info stored at bootstrap time as well.
We should drop the --env-type arg and have an --env-config arg, holding a base64-encoded config serialization (with secrets stripped), which should be dumped directly into /environment *before* we write the /initialized node. This also gives us a path for passing things we know we'll need (such as constraints, which will also go in /environment, I think) at bootstrap time, without having to change the bootstrap code again, which is a surprisingly ugly hassle IM(python)E.
Related branches
- The Go Language Gophers: Pending requested
-
Diff: 193 lines (+55/-31)5 files modifiedcmd/jujud/bootstrap.go (+1/-1)
environs/dummy/environs.go (+11/-18)
environs/jujutest/livetests.go (+11/-0)
state/open.go (+15/-4)
state/state_test.go (+17/-8)
Changed in juju-core: | |
assignee: | nobody → Dave Cheney (dave-cheney) |
Changed in juju-core: | |
milestone: | none → 1.2 |
assignee: | nobody → Dave Cheney (dave-cheney) |
Changed in juju-core: | |
milestone: | 1.2 → 2.0 |
status: | New → In Progress |
milestone: | 2.0 → 1.2 |
Changed in juju-core: | |
milestone: | 1.2 → 2.0 |
milestone: | 2.0 → 1.2 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
milestone: | 1.2 → 1.3 |
Changed in juju-core: | |
status: | Fix Committed → In Progress |
Changed in juju-core: | |
status: | In Progress → Fix Released |
I'm respectfully removing myself from this bug (for the moment) as this is not the issue I thought it was. This is not a comment on the importance of this bug, just unrelated to the piece of code I was working which triggered this bug report during review.