make lint command is failing

Bug #1660715 reported by ABHAY
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-ci-tools
Triaged
Low
Unassigned

Bug Description

make lint command is failing in latest code checked out from main branch. please see below the details of bug description.
make lint is running with flake8 version 3.2.1

*********************************

abc@abc-Latitude-E6420:~/juju-testing/new_code/juju-ci-tools$ make lint
python3 -m flake8 --builtins xrange,basestring "assess_model_change_watcher.py"
flake8 $(find -name '*.py') --builtins xrange,basestring --exclude "assess_model_change_watcher.py"
./quickstart_deploy.py:81:1: E305 expected 2 blank lines after class or function definition, found 1
./start_libvirt_domain.py:17:1: E305 expected 2 blank lines after class or function definition, found 1
./perfscale_controller_stress.py:87:1: E305 expected 2 blank lines after class or function definition, found 1
./assess_user_grant_revoke.py:376:1: E305 expected 2 blank lines after class or function definition, found 1
./perfscale_longrunning.py:136:1: E305 expected 2 blank lines after class or function definition, found 1
./assess_heterogeneous_control.py:183:1: E305 expected 2 blank lines after class or function definition, found 1
./upload_jenkins_job.py:17:19: E275 missing whitespace after keyword
./upload_jenkins_job.py:378:1: E305 expected 2 blank lines after class or function definition, found 1
./run_chaos_monkey.py:93:1: E305 expected 2 blank lines after class or function definition, found 1
./run_deploy_job_wr.py:40:1: E305 expected 2 blank lines after class or function definition, found 1
./stop_libvirt_domain.py:17:1: E305 expected 2 blank lines after class or function definition, found 1
./perfscale_deployment.py:81:1: E305 expected 2 blank lines after class or function definition, found 1
./tests/test_verify_landscape_bundle.py:7:36: E275 missing whitespace after keyword
./tests/test_winazure.py:16:1: E402 module level import not at top of file
./tests/test_winazure.py:21:1: E402 module level import not at top of file
./tests/test_schedule_chaos_tests.py:10:33: E275 missing whitespace after keyword
./tests/test_verify_mediawiki_bundle.py:16:36: E275 missing whitespace after keyword
./gotesttarfile.py:110:1: E305 expected 2 blank lines after class or function definition, found 1
./add-missing-result-yaml-files.py:132:1: E305 expected 2 blank lines after class or function definition, found 1
./scale_out.py:88:1: E305 expected 2 blank lines after class or function definition, found 1
Makefile:6: recipe for target 'lint' failed
make: *** [lint] Error 1

Tags: tech-debt
Curtis Hovey (sinzui)
Changed in juju-ci-tools:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

Since the suite does define an exact version of pyflakes, we get inconsistent results. There are also user rules that leak. We need to force the versions of flake8 used by lint and ensure it can be installed on all supported hosts

tags: added: tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.