assess_resource_charmstore broken by www.jujugui.org move

[Curtis Hovey]

As seen in
   http://reports.vapour.ws/releases/issue/576a867d749a560e33f7c293

The test broke during the holidays. www.jujugui.org was moved and the cert is not valid for all subdomains.
    e-macaroon: x509: certificate is valid for juju-b4d3a0-44.c.jaas-001.internal, not api.jujugui.org

jrwren states that the test should only use http://www.jujugui.org/charmstore. I set JUJU_CHARMSTORE, but it was overridden by the test. I see that jujucharm.sane_charm_store_api_url will replace www with api in the url.

I see that the job is running a fork of juju-ci-tools, resource-juju-ci-tools, on the feature-slave. This hack did not fix the test!

=== modified file 'jujucharm.py'
--- jujucharm.py 2016-09-21 19:03:50 +0000
+++ jujucharm.py 2017-01-11 15:04:39 +0000
@@ -175,4 +175,7 @@
 def sane_charm_store_api_url(url):
     if url is None:
         return CharmCommand.default_api_url
+ return '{}/charmstore'.format(url)
- return '{}/charmstore'.format(re.sub('//(www\.)?', '//api.', url))

We need to remove the fork and fix the test.

[Curtis Hovey (sinzui)]

This issue is actually in the jujugui.org db. We are tracking this issue in juju-ci-tools because it has the tests that will prove the fix.