Review org.jquantlib.math.optimization.EndCriteria

[Richard Gomes]

High Priority Correctness [H C IP] A parameter is dead upon entry to a method but overwritten [IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN]
In class org.jquantlib.math.optimization.EndCriteria
In method org.jquantlib.math.optimization.EndCriteria.checkMaxIterations(int, EndCriteria$CriteriaType)
Local variable named ecType
At EndCriteria.java:[line 85]

[H C IP] A parameter is dead upon entry to a method but overwritten [IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN]

The initial value of this parameter is ignored, and the parameter is overwritten here. This often indicates a mistaken belief that the write to the parameter will be conveyed back to the caller.

=============
Relationships
=============
related to http://bugs.launchpad.net/bugs/jquantlib-200
related to http://bugs.launchpad.net/bugs/jquantlib-416

[Richard Gomes (frgomes)]

1. Please do a code review on EndCriteria

2. Please finish translation of OptimizerTest.java

[Richard Gomes (frgomes)]

Kicked to v0.1.4