PMD :: analise design rules and controversial rules

[Richard Gomes]

Discuss how design rules and controversial rules can be used:
* http://pmd.sourceforge.net/rules/index.html#Design_Rules
* http://pmd.sourceforge.net/rules/index.html#Controversial_Rules

=============
Relationships
=============
related to http://bugs.launchpad.net/bugs/jquantlib-55
related to http://bugs.launchpad.net/bugs/jquantlib-56

[Satyendra Gurjar (satyendragurjar)]

following design and controversial rules could be helpful. comments/feedback?

design rules
============
ConstructorCallsOverridableMethod
FinalFieldCouldBeStatic
CloseResource
InstantiationToGetClass
MissingBreakInSwitch
UseCollectionIsEmpty

controversial rules
============
CallSuperInConstructor
DefaultPackage
AvoidUsingShortType
DoNotCallGarbageCollectionExplicitly

[Richard Gomes (frgomes)]

Could you please review my comments and eventually suggest something else?
Would you like to contribute to activate these rules?

design rules
============
ConstructorCallsOverridableMethod - agreed

FinalFieldCouldBeStatic - agreed

CloseResource - agreed
(in spite we dont employ Connection, Statement and ResultSet in JQL)

InstantiationToGetClass - agreed

MissingBreakInSwitch - agreed
(need to evaluate if this rule generate false positives)

UseCollectionIsEmpty - agreed

controversial rules
============
CallSuperInConstructor - agreed

DefaultPackage - disagree.
Reason: We have a specifig annotation (@PackagePrivate) which is intended to explicitly tell a certain field of method is package private, i.e: a 'default' visibility (nothing specified, in fact) should be considered wrong and one shoule explicitly use @PackagePrivate in order to explicitly state what is needed. There's also rules intended to detect missing @PackagePrivate annotation on methods, fields and classes.

AvoidUsingShortType - agreed

DoNotCallGarbageCollectionExplicitly - agreed

[Richard Gomes (frgomes)]

Kicked to v0.1.4