Debian/Ubuntu JOSM license file is outdated

[Don-vip]

Hi, JOSM developers here. We found that the license file delivered in Debian/Ubuntu packages for JOSM is outdated and contains some problems.

This problem applies to all versions.

From https://josm.openstreetmap.de/ticket/9590#comment:7 and comments that follow, please consider:

- Do not mix JOSM (org/openstreetmap/josm) and JMapViewer (org/openstreetmap/jmapviewer) code, they're distinct products with distinct list of authors
- I have updated list of auhors for JMapViewer according to your format, here: https://trac.openstreetmap.org/browser/subversion/applications/viewer/jmapviewer/Readme.txt
- We won't provide copyright years for JOSM list of authors, however the complete list of authors, in alphabetical order, is here: https://josm.openstreetmap.de/browser/josm/trunk/CONTRIBUTION Can you please stick to this list ? For years, please remove them or make sure they are always correct.
- The license appears to be wrong (see above ticket comments for details)
- The file src/org/openstreetmap/josm/io/MultiPartFormOutputStream.java does not exist
- See our list of external code with authors and license in CONTRIBUTION file
- The file images/world.jpg has been deleted 5 years ago: https://josm.openstreetmap.de/changeset/1680/josm
- Unless it is ont of external source files listed in CONTRIBUTION, please do not create separate entries for files inside src/org/openstreetmap/josm (like Changeset.java or TigerUtils.java) as the whole JOSM copyright applies.
- There's a big problem with copyright for .po files. I do not know where your values come from, but it is more complicated than that. Either remove copyright or use the complete list of contributors for each language. As we are still using Launchpad right now, I assume you are more familiar than us to retrieve this information correctly.

[Logan Rosen (logan)]

I just synced josm 0.0.svn6502+dfsg3-1 into Ubuntu Trusty, which appears to fix a number of licensing issues. Can you please prune down your list accordingly? Then, I'll forward it to Debian so that your concerns can be handled by the maintainers. :)

[David Paleino (dpaleino)]

Hey all,

I'm currently working on updating JOSM on Debian; and I've noticed the
copyright file was outdated. The version in experimental still contains
wrong information; but I'm working on it, don't worry :)

--
. ''`. Debian developer | http://wiki.debian.org/DavidPaleino
: :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
`. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
 `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[Don-vip (vincent-privat)]

Hi David,
any news on JOSM update in Debian? Can we help you somehow?

[Bas Couwenberg (sebastic)]

I'm updating the copyright file in the josm package maintained by the Debian GIS team to addres these issues.

Don-vip (vincent-privat) on 2014-01-27:
> - There's a big problem with copyright for .po files. I do not know where your values come from, but it is more complicated than that. Either remove copyright or use the complete list of contributors for each language. As we are still using Launchpad right now, I assume you are more familiar than us to retrieve this information correctly.

The copyright information may have been retrieved from the Last-Translator headers in the .po, or the VCS repo history.

I am not familiar with Launchpad translations, but I cannot seem to find any list of contributors to the JOSM translations. The bzr log for the repo at lp:~openstreetmap/josm/josm_trans/ is not informative either.

I'm tempted to remove the translation paragraphs from the copyright file placing them under the same copyright and license as JOSM, but they have differences sources and contributors so the translations should be documented separately.

Is it possible to document the copyright and license applicable to the translations available at lp:~openstreetmap/josm/josm_trans/ ?

The README.TXT at http://svn.openstreetmap.org/applications/editors/josm/i18n/ also doesn't document the license and copyright.

[Bas Couwenberg (sebastic)]

Launchpad documents the license for translations in the LicensingFAQ as BSD-3-Clause and the copyright for the translations is listed in the .po comments (which were stripped in the get-orig-source target), so documenting it explictly would be nice but it's not required.

https://help.launchpad.net/Translations/LicensingFAQ#license-text

I've updated the Debian package in the Debian GIS team git repo, all issues with the copyright file should now be resolved. See:

http://anonscm.debian.org/cgit/pkg-grass/josm.git/tree/debian/copyright

[Don-vip (vincent-privat)]

This is much better, thank you very much :)
Only two remarks left:
1. Why is the Launchpad copyright sopping at 2013 instead of 2014?
2. Entries for i18n/po/en_GB.po and i18n/po/tr.po should be removed

After that, well the file looks fine to me :)

[Bas Couwenberg (sebastic)]

On 11/24/2014 11:55 PM, Don-vip wrote:
> 1. Why is the Launchpad copyright [stopping] at 2013 instead of 2014?

Because the copyright statements in the .po file headers only list a
single year, and the statements for the various files are grouped.

$ grep -h "# Copyright" po/josm/*.po | sort | uniq -c | sort -nr
     36 # Copyright (c) 2009 Rosetta Contributors and Canonical Ltd 2009
     14 # Copyright (c) 2008 Rosetta Contributors and Canonical Ltd 2008
      7 # Copyright (c) 2007 Rosetta Contributors and Canonical Ltd 2007
      5 # Copyright (c) 2010 Rosetta Contributors and Canonical Ltd 2010
      3 # Copyright (c) 2011 Rosetta Contributors and Canonical Ltd 2011
      2 # Copyright (c) 2012 Rosetta Contributors and Canonical Ltd 2012
      1 # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
      1 # Copyright (c) (c) 2006 Canonical Ltd, and Rosetta Contributors
2006
      1 # Copyright (c) 2013 Rosetta Contributors and Canonical Ltd 2013
      1 # Copyright (C) 2009 ikinokta
      1 # Copyright (c) 2006 Rosetta Contributors and Canonical Ltd 2006
      1 # Copyright (C) 2006 Immanuel Scholz

The "Rosetta Contributors and Canonical Ltd" copyright statements are
grouped into a single multi year statement.

> 2. Entries for i18n/po/en_GB.po and i18n/po/tr.po should be removed

Why? The copyright statements for these files specify different authors:

# Copyright (C) 2006 Immanuel Scholz
i18n/po/en_GB.po

# Copyright (C) 2009 ikinokta
i18n/po/tr.po

Because these files list different authors, I prefer to list them
separately instead adding the years & authors to the Copyright field of
the others.

Both approaches are conforming to copyright-format 1.0, see:

https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field

When the copyright of the translation files is updated, I'll update the
copyright file in the Debian package accordingly.

Kind Regards,

Bas

--
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1

[Don-vip (vincent-privat)]

OK, I thought it was a mistake. The copyright file is fine then, this issue can be closed :)

[Bas Couwenberg (sebastic)]

On 11/25/2014 09:34 PM, Don-vip wrote:
> OK, I thought it was a mistake. The copyright file is fine then, this
> issue can be closed :)

This issue should automatically be closed when the updated josm package
from Debian is synced into Ubuntu (using the LP bug ID in the package
changelog).

The next JOSM tested snapshot will be the first revision of the Debian
package to include the updated copyright file.

Kind Regards,

Bas

--
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1

[Daniel Holbach (dholbach)]

This bug was fixed in the package josm - 0.0.svn7995+dfsg1-1~exp1

---------------
josm (0.0.svn7995+dfsg1-1~exp1) experimental; urgency=medium

  * New tested snapshot.
  * Drop runtime dependency on ant, its bzip2 support is no longer used.
  * Refresh patches.

 -- Bas Couwenberg <email address hidden> Sun, 01 Feb 2015 20:00:18 +0100

josm (0.0.svn7906+dfsg2-1~exp1) experimental; urgency=medium

  * New tested snapshot.
  * Add (build) dependency on libcommons-compress-java,
    its bzip2 support is now used instead of Apache Ant.
  * Install upstream man page.
  * Also remove Windows installer from upstream tarball.
  * Refresh patches.
  * Bump minimum requires jmapviewer version to 1.05, JOSM uses the
    TMSFileCacheTileLoader class introduced in JMapViewer 1.05.

 -- Bas Couwenberg <email address hidden> Tue, 30 Dec 2014 19:09:10 +0100

josm (0.0.svn7778+dfsg1-1~exp2) experimental; urgency=medium

  * Add alternative dependency on minimum required JRE.
  * Update Vcs-* fields to use pkg-grass instead of pkg-osm,
    and cgit instead of gitweb.
  * Disable FTBFS causing translation in d/rules instead of removing it
    in d/clean.

 -- Bas Couwenberg <email address hidden> Sun, 14 Dec 2014 13:49:10 +0100

josm (0.0.svn7778+dfsg1-1~exp1) experimental; urgency=medium

  * New tested snapshot (7777) + next revision to include logo fix for Linux.
    Thanks to Vincent Privat for the notification about the logo fix.
  * Update watch file to use the pkg-grass JOSM Redirector.
  * Update copyright file:
    - Add comment with the GPL-2+/GPL-3+/Apache-2.0 information from LICENSE
      file
    - Correct license from GPL-3+ to GPL-2+ for JOSM
    - Update JOSM contributors list
    - Add License section for GPL-2 with Classpath exception and CDDL-1.1
    - Add Files section for Glassfish JSON source using GPL-2 with Classpath
      exception or CDDL-1.1
    - Add License section for BSD-2-Clause
    - Add Files section for openhours Javascript source using BSD-2-Clause
    - Add License section for GPL-1+
    - Add Files section for Diff source using GPL-1+
    - Correct license from GPL-3+ to BSD-3-Clause for JOSM translations.
    (LP: #1273178)
  * Strip comments from translations, but preserve copyright header.
  * Install the appstream appdata.xml file.
    Thanks to Marcus Lundblad for the patch.
    (closes: #770881)
  * Add upstream metadata.
  * Refresh patches.

 -- Bas Couwenberg <email address hidden> Wed, 10 Dec 2014 22:02:33 +0100