application icon should be a dynamic path and name

[Jeff Fortin Tam]

The content of jokosher.desktop is this:
Icon=/usr/share/jokosher/images/jokosher-icon.png

This completely *breaks* icon themes (icon theme makers cannot theme jokosher's icon). A correct line would be:

Icon=jokosher

Then, Jokosher's "official" icon should be installed in the HighContrast theme. Then, the .desktop file will look for it automagically. (See http://code.google.com/p/specto/issues/detail?id=25&can=1&q=icon for an example)

[David Corrales (davidcorrales)]

After checking our current svn jokosher.desktop and setup.py files, I found that they comply with the restrictions requested. The file does get copied to the hicolor folder, and the desktop file references a single file name (not a path).

[Jeff Fortin Tam (kiddo)]

Just checked Trunk, indeed the Icon=jokosher-icon.png, wouldn't it make sense to use Icon=jokosher instead? I don't know exactly why an app icon should contain "-icon" in its filename. Furthermore, specifying "jokosher" instead of "jokosher.png" allows for any icon image type to be used (svg, png, etc). What do you think?

[David Corrales (davidcorrales)]

I'll try removing the extension and test it again.
The -icon is there because there's another jokosher-logo image. This second
point isn't really as relevant as the first one though.
Thanks for the input :)

On 3/16/07, Jeff Fortin <email address hidden> wrote:
>
> Just checked Trunk, indeed the Icon=jokosher-icon.png, wouldn't it make
> sense to use Icon=jokosher instead? I don't know exactly why an app icon
> should contain "-icon" in its filename. Furthermore, specifying
> "jokosher" instead of "jokosher.png" allows for any icon image type to
> be used (svg, png, etc). What do you think?
>
> --
> application icon should be a dynamic path and name
> https://launchpad.net/bugs/92615
>

[Jeff Fortin Tam (kiddo)]

Yeah, it's just that icon theme makers can more easily guess "jokosher" than "jokosher-icon" (as the vast majority of apps out there match apps/$appname).

As it doesn't conflict with the logo (which has a different filename), I would "recommend" naming the icon just "jokosher", but that's up to you I guess ;)