The space bar keystroke should be assigned to play/stop

Bug #73670 reported by David Corrales
4
Affects Status Importance Assigned to Milestone
Jokosher
Confirmed
Wishlist
Unassigned

Bug Description

Right now, the space bar toggles the last selected control. It should be assigned to starting/stopping playback for usability issues.

Tags: usability
Revision history for this message
David Corrales (davidcorrales) wrote :

Due to design issues, it's not possible (or at least not documented) to catch the space bar event with the current GTK toolkit.

Changed in jokosher:
importance: Undecided → Wishlist
status: Unconfirmed → Confirmed
Revision history for this message
Laszlo Pandy (laszlok) wrote :

Wrong, it is possible we just screwed it up in our code. Fixed now.

Changed in jokosher:
status: Confirmed → Fix Committed
Laszlo Pandy (laszlok)
Changed in jokosher:
status: Fix Committed → Confirmed
Revision history for this message
Jeff Fortin Tam (kiddo) wrote :

Dang, this bug report is ancient!
The 0.13.x series of PiTiVi have this implemented correctly. Since it's python+gtk+gnonlin too, just borrow their code?

Revision history for this message
Jeff Fortin Tam (kiddo) wrote :

Oh, I need to specify, as this bug annoys me daily, that it should be assigned to play+pause instead of play+stop in my opinion.

Revision history for this message
Laszlo Pandy (laszlok) wrote :

If it actually is implemented correctly, then yeah we can use the code. I'll take a look at it.

Revision history for this message
Jeff Fortin Tam (kiddo) wrote : Re: [Bug 73670] Re: The space bar keystroke should be assigned to play/stop

Well, implemented correctly from the "user's point of view", don't know
about the beauty of the code ;) they did have to add an exception somewhere
to prevent it from being used in areas other than the timeline (such as
toolbars and the source list), though.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote : Re: [Bug 73670] Re: The space bar keystroke should be assigned to play/stop

We already have the "p" and "r" hotkeys for playing and recording; space
is currently used for performing splits via the keyboard.

Laszlo Pandy wrote:
> If it actually is implemented correctly, then yeah we can use the code.
> I'll take a look at it.
>

Revision history for this message
Laszlo Pandy (laszlok) wrote :

What i meant by "correctly" is that it is fairly straight forward to bind an application global keypress of space to play/pause. The difficult part is making sure you don't make the application totally unusable to people without a mouse. Space is used to activate the focussed element, like a button, or even to so splits when the waveform has focus as Michael mentions.

Revision history for this message
Jeff Fortin Tam (kiddo) wrote : Re: [Bug 73670] Re: The space bar keystroke should be assigned to play/stop

Shouldn't it be reversed? Spacebar for playback control is 1) much more
common in all the video/audio editors I've seen 2) used much more often than
splitting. Splitting could be assigned to the 'S' key or something.

Revision history for this message
Laszlo Pandy (laszlok) wrote :

Even if we change the splitting function that does doesn't solve the problem of keyboard only users using spacebar to click the focussed button.

Revision history for this message
Jeff Fortin Tam (kiddo) wrote : Re: [Bug 73670] Re: The space bar keystroke should be assigned to play/stop

Yeah, spacebar should work only when the timeline is focused and not a
regular gtk widget (afaict that's how PiTiVi behaves).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.