[PATCH] Instrument view tweaks

[Denis Washington]

This patch tweaks the instrument view and the controls box slightly. In particular it:

* gives the instrument icon a small padding so that it seems less crammed. (I would also propose to reduce the icon's size to 32px so that the instruments take up less vertical space, but that's not implemented in the patch.)

* makes the instrument title bold so that it looks less lost, and increase it's width to 16 characters; with 12 characters, even names like "Acoustic Guitar" were already ellipsized.

* sets the control box button reliefs to NONE. This makes it pretty easy to see which buttons are enabled and which aren't. (See ticket #167)

[Laszlo Pandy (laszlok)]

In the description you have put three good points. I'm not sure if you are right, but they might be better than what we have now. However just looking at Jokosher with this patch applied makes it ugly. The reason I haven't made the buttons no relief before is because i think they look ugly and not like buttons (and so less discoverable). Also I think having bold text for the instrument name is against the Human Interface Guidlines, and if it isn't it should be because it looks like it doesn't belong.

Can someone else take a look at this and give me their opinion. This patch is probably more about taste than anything technical.

[Denis Washington (dwashington)]

I admit that the bold text is probably a pure matter of taste, I also wouldn't have any problem with removing this part from the patch. However, I think the reliefless buttons may be a real benefit from the usability apect; but maybe there is a better way of making toggled/not-toggled visually better distinguishable?