[patch] toolbar not HIG compliant (or at least, not pretty), and fix for bug #116474

Bug #117478 reported by Jeff Fortin Tam on 2007-05-29
2
Affects Status Importance Assigned to Milestone
Jokosher
Undecided
Unassigned

Bug Description

The current toolbar is beyond ugly; it makes any gtk theme look weird because of the "workspace switching" buttons and timebox on the right. After months of fiddling around, I finally found a solution. Turns out that I was able to add an "event box" to the toolbar, using Glade 3.2 (I was not able to figure out how to do that with glade 2.0... the user interface is really terrible).

The only problem is that I can hardly provide a "really clean patch", because the .glade files generated by glade 3.2 are different than those of glade 2.0. They are backwards and forwards compatible, don't worry, it's just that you won't be able to just see the differences using diff.

I would suggest you guys use Glade3 (available in the ubuntu repositories for a while) instead of glade2. The files it generates are a lot cleaner (and lighter! look at mine, it's 195 kilobytes instead of 225 kilobytes, a 13.3% filesize reduction!)

Soooo, back to the main issue. I did not remove the horizontalbox that contained the toolbar, I just set its number of columns to 1 (but you can remove it; this is what I would recommend for simplicity). And now that everything is inside the toolbar, Jokosher looks perfectly integrated with any GTK theme.

To help you with finding out my changes, I think the relevant lines are: 513 to uh... something like 753 maybe?

contents of the tarball I will be attaching:
- ugly.png: screenshot (zoom 200%) of the "vanilla" jokosher toolbar in the 0.9 release. Notice how the toolbar's borders at the top and bottom kind of "cut off" right before the workspace switching thingy? That is the big thing that made me file this bug.
- good.png: screenshot of my patched svn
- Jokosher.glade: my modified glade file

By the way, my changes also fix bug #116474 ("Toolbar doesn't obey GNOME desktop-wide settings"). What I do is simply remove this line:
<property name="toolbar_style">GTK_TOOLBAR_BOTH</property>

It's that simple. Now jokosher will follow the gtk settings for toolbar sizes too. Yay, yay! I hope this "half-patch" is useful to you guys. Please accept/adapt it :)

Jeff Fortin Tam (kiddo) wrote :
Laszlo Pandy (laszlok) wrote :

We did use glade 3 for a bit but at that time is was broken in a number of ways and we had to revert back to glade2. Since then its gotten a lot better, but we are still waiting on one bug:
http://bugzilla.gnome.org/show_bug.cgi?id=364078

Until that is fixed, the glade file will stay in the glade2 format.

Jeff Fortin Tam (kiddo) wrote :

sorry to hear that :) well I hope you will be able to figure out the changes in my glade file compared to the one in svn (sadly, Meld can be of no use here, glade3 made too much indentation changes)

Jeff Fortin Tam (kiddo) wrote :

Have you been able to try the changes in lines ~513-753 yet? Can this make it into Jokosher 1.0?

Jeff Fortin Tam (kiddo) wrote :

I see that a different fix has been applied in current Trunk. No more need for my patch it seems. I love the toggle button.

Changed in jokosher:
status: New → Fix Committed
Changed in jokosher:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers