"e" key does not start export on firefox

[Tristan BENOIST]

When opening test presentation "JessyInk_1_5_5_showcase.svg" in firefox (21.0), the "e" key (alone) does not initiate export (no dialog box).

[Tristan BENOIST (tristan-benoist)]

other keys (d for example) are working.

[Hannes Hochreiner (hannes-hochreiner)]

Looks like Mozilla deprecated the function JessyInk uses to serialize the document.

https://developer.mozilla.org/en/docs/XMLSerializer

I will try and modify the function to make it work again. Thanks for letting me know.

[Sebastian Hofer (sebhofer-gmail)]

Hi Hannes,

is this problem really fixed? I'm using Firefox 24 on Linux Mint Debian and I'm still not getting the export dialog on pressing 'e'. Is this a problem with my setup?

Thanks for JessyInk btw :) I use it a lot!

[Roland Whitehead (rolandw)]

Hi Hannes,

Unfortunately this problem also occurs in Firefox 27.

[Tristan BENOIST (tristan-benoist)]

Seems the error is back. The solution is simple as Hannes told, XMLSerilazer.toStream is deprecated. One needs to use toString in replacement.
The fix is the same as the one Hannes gave at the time I posted thos bug. It is the following : Edit your svg file with a text editor. Find the part begining with "// Serialise the new document." It should be :
var serializer = new XMLSerializer();
 var strm =
 {
  content : "",
  close : function() {},
  flush : function() {},
  write : function(str, count) { this.content += str; }
 };

 var xml = serializer.serializeToString(newDoc, strm, 'UTF-8');

 window.location = 'data:application/svg+xml;base64;charset=utf-8,' + window.btoa(strm.content);

Replace this whole block with :
w.location = 'data:application/svg+xml;base64;charset=utf-8,' + window.btoa(unescape(encodeURIComponent((new XMLSerializer()).serializeToString(newDoc))));

This should do the trick waiting for a proper fix or update on the jessyink version included in inkscape.

[Sebastian Hofer (sebhofer-gmail)]

Tristan,

this indeed works, but only if you replace "w.location" in your code with "window.location" as in the original. Now I also see why export didn't work for me, I think I have to reinstall the javascript in the svg file.

Thanks for the hint!

[Foivos Zakkak (foivos)]

To fix it for all future presentations in your system apply the corresponding patch.

wget https://bazaar.launchpad.net/~hannes-hochreiner/jessyink/trunk/diff/125 -O /tmp/export.diff
cd /usr/share/inkscape/extensions
sudo patch -p1 < /tmp/export.diff

[jazzynico (jazzynico)]

Inkscape still uses Jessyink v1.5.5 and thus is affected by the bug. I'm going to apply the patch from Bug #1397317, comment #1.

@Hannes, I see some of the changes committed between JessyInk r.116 (1.5.5) and r.125 (not tagged in the revision list yet) have already been applied to Inkscape, but not all. I suggest we update JessyInk to the very latest stable version in 0.92 as soon as 0.91 is out. Do you have plans for JessyInk 2.0? Or should we still use the 1.5 branch?

[jazzynico (jazzynico)]

Fix committed in the 0.91 branch (rev. 13672) and trunk (rev. 13781).

[Hannes Hochreiner (hannes-hochreiner)]

Please use the 1.5 branch. I have not made much progress on the 2.0 branch and there are still quite a few features missing.