Catch-all bug for issues with hps & mana

[Gatt]

Steps to reproduce:

Login an existing character with eq in rent.
wear eq

Result:

Every tick the player's max hps and max mana alter, in most cases going into minus numbers. Same applies to regen stats.

Note, doesn't happen to a newbie char, perhaps because his eq doesn't have any affects flags?

Expected results:

Normal eq affects applied

Impact:

[Gatt (gatt)]

Further detail:

I hold a philo, which is +30 mana.
Tick passes and I lose 30 from max mana.
I remove the philo and I lose another 30 from max mana.

I wear arcanes, which are +15 mana.
Tick passes and I lose 30 from max mana.
I remove arcanes and lose a further 30 from max mana.

Looks like a pattern to me :)

So it's not the +mana affect that is being applied inversely to max-mana, it's something else which = 30.

A similar effect occurs if you wear shimmering sandals which have a mana-regen affect but on removing them my mana regen drops by about 96, consistently.

So affects are being applied correctly by affect-type but they are being applied to the wrong stat and the wrong affect-amount is being applied.

That's what I think I'm seeing anyway.

[Austinpowers (austinpowers)]

Issue stems from multiple issues. AFF_FLAGS were incorrect on objects, causing a mass issue when in use. Second issue is, rent files are off a bit, I will go through line by line to make sure they were saved out correctly. Next issue is/was applies were incorrectly subtracting bonus's due to my mistake on the way I saved out real_abils vs. aff_abils and regen. I swapped the regen rates vs natural regen saves.

I have validated that a mortal with no eq, has no issues with regen rates, mana, hp, or moves. I have got cunning destroyed a few times now.

Futher testing to commence 6/11/10

[Austinpowers (austinpowers)]

I trying to identify the issue with ticks. I have corrected the entire tick/heartbeat system. Which can be tweaked via the new CEDIT (Game Configuration editor). A nake character has no issues, I can affect all stats with spells and we are good. I have checked regen, and that is correct. Eating/drinking/drunk is also not affected. I have to make one last check of the objects and test 1 at a time to make sure the rent objects are not causing any more issues.

I did discover an issue does exist when character has eq on and you can cure critic or any other healing. IE it fubars hp and mana.

I will work to identify further.

[Austinpowers (austinpowers)]

After finally getting around to updating the PULSE system (aka ticks, heartbeats, rails, etc etc) I have updated the code to use point_update and something else that escapes me while at work. I have tested Cunning as my character. There was no issues with regen over a 3 hour span. Multiple logging of regen and point(mana, hp, move) show that the character now keeps all their stats as intended with or without equpiment.

I had to also go through the affects code to bring it up to the new code addtions. I have removed the old new_affect_update and affect_update, and made it just one function that uses most of the new_affect_update code. This keeps in line with circlemud 3.0 and keeps jedi's perma affects. I have also combined the char_point_update and mobile_point_update and object_update () code into 2 seperate functions that conforms to the circlemud 3.0 format.