boot from iso test orphans a node in a provisioned state

[Julia Kreger]

After running the ironic_standalone job:

stack@np0036907443:~$ OS_CLOUD=devstack-system-admin openstack baremetal node list
+------------------------+--------+---------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+------------------------+--------+---------------+-------------+--------------------+-------------+
| b40eeaf8-7ca0-48b5- | node-0 | None | power off | available | False |
| 8a66-60571589b61a | | | | | |
| 97b26f0b-2e43-426a- | node-1 | None | power off | available | False |
| 8ac3-aa79e7df9819 | | | | | |
| e8550efa-32a1-4b07- | node-2 | None | power off | available | False |
| a4a4-2926509d539b | | | | | |
| 30d64edd-afcc-4f11- | node-3 | None | power on | active | False |
| 9cbf-3411fbcd8f5d | | | | | |
+------------------------+--------+---------------+-------------+--------------------+-------------+
stack@np0036907443:~$ OS_CLOUD=devstack-system-admin openstack baremetal node show node-3

+------------------------+-----------------------------------------------------------------------------+
| Field | Value |
+------------------------+-----------------------------------------------------------------------------+
| allocation_uuid | None |
| automated_clean | None |
| bios_interface | no-bios |
| boot_interface | ipxe |
| boot_mode | None |
| chassis_uuid | eae0f4d0-1dea-4536-b7e7-44e9862b2751 |
| clean_step | {} |
| conductor | np0036907443 |
| conductor_group | |
| console_enabled | False |
| console_interface | no-console |
| created_at | 2024-02-28T20:59:47+00:00 |
| deploy_interface | ramdisk |
| deploy_step | {} |
| description | None |
| driver | ipmi |
| driver_info | {'ipmi_address': '173.231.255.102', 'ipmi_username': 'admin', |
| | 'ipmi_password': '******', 'ipmi_port': 6233} |
| driver_internal_info | {'deploy_steps': None, 'last_power_state_change': |
| | '2024-02-29T20:53:10.356647', 'agent_version': '9.9.1.dev5', |
| | 'agent_last_heartbeat': '2024-02-29T20:49:35.078315', |
| | 'hardware_manager_version': {'generic_hardware_manager': '1.2'}, |
| | 'agent_cached_deploy_steps_refreshed': '2024-02-29T20:49:07.566614', |
| | 'clean_steps': None, 'agent_erase_devices_iterations': 1, |
| | 'agent_erase_devices_zeroize': True, |
| | 'agent_continue_if_secure_erase_failed': False, |
| | 'agent_continue_if_ata_erase_failed': False, |
| | 'agent_enable_nvme_secure_erase': True, 'agent_enable_ata_secure_erase': |
| | True, 'disk_erasure_concurrency': 4, 'agent_erase_skip_read_only': False, |
| | 'agent_cached_clean_steps_refreshed': '2024-02-29T20:01:29.999277'} |
| extra | {} |
| fault | None |
| firmware_interface | no-firmware |
| inspect_interface | no-inspect |
| inspection_finished_at | None |
| inspection_started_at | None |
| instance_info | {'boot_iso': |
| | 'http://mirrors.dotsrc.org/tinycorelinux/14.x/x86/release/Core- |
| | current.iso'} |
| instance_uuid | None |
| last_error | None |
| lessee | None |
| maintenance | False |
| maintenance_reason | None |
| management_interface | ipmitool |
| name | node-3 |
| network_data | {} |
| network_interface | flat |
| owner | None |
| parent_node | None |
| power_interface | ipmitool |
| power_state | power on |
| properties | {'cpu_arch': 'x86_64', 'capabilities': 'boot_mode:uefi', 'vendor': |
| | 'unknown'} |
| protected | False |
| protected_reason | None |
| provision_state | active |
| provision_updated_at | 2024-02-29T20:53:21+00:00 |
| raid_config | {} |
| raid_interface | agent |
| rescue_interface | agent |
| reservation | None |
| resource_class | baremetal |
| retired | False |
| retired_reason | None |
| secure_boot | None |
| shard | None |
| storage_interface | noop |
| target_power_state | None |
| target_provision_state | None |
| target_raid_config | {} |
| traits | ['CUSTOM_GOLD', 'CUSTOM_RAID'] |
| updated_at | 2024-02-29T20:53:35+00:00 |
| uuid | 30d64edd-afcc-4f11-9cbf-3411fbcd8f5d |
| vendor_interface | ipmitool |
+------------------------+-----------------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/914980

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/914980
Committed: https://opendev.org/openstack/ironic-tempest-plugin/commit/80c6b5140a0c0ac13d3eb3d4da4d1403a497534e
Submitter: "Zuul (22348)"
Branch: master

commit 80c6b5140a0c0ac13d3eb3d4da4d1403a497534e
Author: Julia Kreger <email address hidden>
Date: Wed Apr 3 07:24:51 2024 -0700

    Unprovision iso ramdisk boot from test

    The boot_iso ramdisk test unfortunately has been discovered to
    orphan occupied "nodes" after the test has executed. This change
    triggers the test to send a command to force the node to be
    unprovisioned at the end of the test.

    Closes-Bug: 2055469
    Change-Id: Ib525fe099d5884f442cdc375c5a8d230710d20a4