Ironic

[RFE] Stop special handling of mime extensions in the API

Bug #1748224 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
In Progress
Wishlist
Afonne-CID

Bug Description

Previously we treated things like /v1/nodes/test.1 as node with name "test" returned as man page. This obvious misbehavior was fixed in https://bugs.launchpad.net/ironic/+bug/1643995. However, we still treat /v1/nodes/test.json as node "test" if it exists and only fall back to node "test.json" if it does not.

This RFE suggests introducing an API version where any special treatment of .json is disabled in the API. So, in this version /v1/nodes/test.json will only mean node with name "test.json", and /v1/nodes.json will be HTTP 404.

Revision history for this message
Ruby Loo (rloo) wrote :

Thanks for reporting this Dmitry. I'm good with approving it.

Revision history for this message
Vladyslav Drok (vdrok) wrote :

+1, don't think spec is needed here.

Revision history for this message
Ruby Loo (rloo) wrote :

jlvillal and TheJulia are good with approving this w/o a spec.

tags: added: rfe-approved
removed: rfe
Nisha Yadav (ynisha11)
Changed in ironic:
assignee: nobody → Nisha Yadav (ynisha11)
Jay Faulkner (jason-oldos)
Changed in ironic:
assignee: Nisha Yadav (ynisha11) → nobody
Afonne-CID (cidelight)
Changed in ironic:
assignee: nobody → Afonne-CID (cidelight)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/913467

Changed in ironic:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.