[RFE] Stop special handling of mime extensions in the API

[Dmitry Tantsur]

Previously we treated things like /v1/nodes/test.1 as node with name "test" returned as man page. This obvious misbehavior was fixed in https://bugs.launchpad.net/ironic/+bug/1643995. However, we still treat /v1/nodes/test.json as node "test" if it exists and only fall back to node "test.json" if it does not.

This RFE suggests introducing an API version where any special treatment of .json is disabled in the API. So, in this version /v1/nodes/test.json will only mean node with name "test.json", and /v1/nodes.json will be HTTP 404.

[Ruby Loo (rloo)]

Thanks for reporting this Dmitry. I'm good with approving it.

[Vladyslav Drok (vdrok)]

+1, don't think spec is needed here.

[Ruby Loo (rloo)]

jlvillal and TheJulia are good with approving this w/o a spec.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/913467

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ironic/+/913467
Committed: https://opendev.org/openstack/ironic/commit/ee5315bcf3364469d5d5200933ab22e1ecdc38c2
Submitter: "Zuul (22348)"
Branch: master

commit ee5315bcf3364469d5d5200933ab22e1ecdc38c2
Author: cid <email address hidden>
Date: Fri Apr 19 03:56:41 2024 +0100

    Remove special treatment of .json for API objects

    - /v1/nodes/test.json will now only mean node with the name
    "test.json"
    - /v1/nodes/test.json.json will mean a node with the name
    "test.json.json" and,
    - /v1/nodes/test will mean a node with the name "test".

    So /v1/nodes/test.json will no longer default to "test" and
    will HTTP 404 unless a node with the name "test" actually exists.

    This also removes the backward compatibility with the
    guess_content_type_from_ext feature

    Closes-Bug: #1748224

    Change-Id: If4b3a23e2a09065f5e063e66cff66b96af4d3393

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 25.0.0 release.