Reno does not choose correct earliest version when old stable branches are closed

[Jim Rollenhagen]

Ironic's first mitaka release was 4.3.0, however, reno picks it up as 5.1.0.

$ cd ironic
$ git checkout 180234b445f7127fb5fc19238636a9967055d741 # master as of filing this bug
$ reno -v report --branch stable/mitaka
scanning ./releasenotes/notes (branch=stable/mitaka earliest_version=None)
looking for ref 'stable/mitaka' as 'refs/heads/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/remotes/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/mitaka-eol'
found ref 'stable/mitaka' as 'refs/tags/mitaka-eol' at fdd01ca736877aa1a877ae4035ae41bb5f241311
current repository version: 5.1.3
looking for ref 'stable/mitaka' as 'refs/heads/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/remotes/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/mitaka-eol'
found ref 'stable/mitaka' as 'refs/tags/mitaka-eol' at fdd01ca736877aa1a877ae4035ae41bb5f241311
versions by date [u'5.1.3', u'5.1.2', u'5.1.1', u'5.1.0', u'5.0.0', u'4.3.0', u'4.2.0', u'4.1.0', u'4.0.0', u'2015.1.0rc2', u'2015.1.0', u'2015.1.0rc1', u'2015.1.0b3', u'2015.1.0b2', u'2015.1.0b1', u'2014.2.rc3', u'2014.2', u'2014.2.rc2', u'2014.2.rc1', u'2014.2.b3', u'2014.2.b2', u'2014.2.b1', u'2014.1.rc1', u'2014.1.b3', u'2014.1.b2', u'2014.1.b1']
determining earliest_version from branch
looking for ref 'master' as 'refs/heads/master'
found ref 'master' as 'refs/heads/master' at 180234b445f7127fb5fc19238636a9967055d741
looking for ref 'stable/mitaka' as 'refs/heads/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/remotes/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/mitaka-eol'
found ref 'stable/mitaka' as 'refs/tags/mitaka-eol' at fdd01ca736877aa1a877ae4035ae41bb5f241311
looking for the branch before stable/mitaka
refs ['refs/tags/8.0.0', 'refs/tags/kilo-eol', 'refs/tags/4.0.0', 'HEAD', 'refs/tags/2014.2.b3', 'refs/tags/2014.2.b2', 'refs/tags/10.0.0', 'refs/tags/6.2.1', 'refs/remotes/gerrit/stable/newton', 'refs/tags/icehouse-eol', 'refs/tags/4.2.4', 'refs/tags/4.3.0', 'refs/tags/2015.1.0rc2', 'refs/tags/mitaka-eol', 'refs/tags/4.2.0', 'refs/tags/2015.1.0rc1', 'refs/tag
s/2015.1.4', 'refs/tags/4.2.5', 'refs/tags/2015.1.2', 'refs/tags/2015.1.3', 'refs/tags/2015.1.0', 'refs/tags/2015.1.1', 'refs/tags/4.2.2', 'refs/tags/6.1.0', 'refs/remotes/origin/stable/ocata', 'refs/tags/5.0.0', 'refs/tags/6.0.0', 'refs/tags/4.2.3', 'refs/tags/5.1.0', 'refs/tags/5.1.1', 'refs/tags/5.1.2', 'refs/tags/5.1.3', 'refs/tags/liberty-eol', 'refs/remo
tes/origin/stable/newton', 'refs/tags/4.2.1', 'refs/remotes/gerrit/master', 'refs/tags/9.0.1', 'refs/tags/9.0.0', 'refs/remotes/origin/master', 'refs/tags/9.1.0', 'refs/tags/9.1.1', 'refs/tags/9.1.2', 'refs/tags/2014.2', 'refs/tags/2014.1.rc2', 'refs/tags/2014.1', 'refs/tags/2014.2.rc1', 'refs/tags/7.0.2', 'refs/tags/2014.2.rc3', 'refs/tags/2014.1.rc1', 'refs/
tags/2014.2.1', 'refs/remotes/gerrit/stable/ocata', 'refs/tags/7.0.1', 'refs/tags/2014.2.rc2', 'refs/remotes/origin/HEAD', 'refs/tags/7.0.0', 'refs/tags/2015.1.0b2', 'refs/tags/2015.1.0b3', 'refs/heads/master', 'refs/tags/2015.1.0b1', 'refs/tags/juno-eol', 'refs/tags/6.2.0', 'refs/tags/2014.2.b1', 'refs/heads/rhel7-devstack', 'refs/remotes/origin/stable/pike',
 'refs/remotes/gerrit/stable/pike', 'refs/tags/9.2.0', 'refs/tags/6.2.2', 'refs/tags/4.1.0', 'refs/tags/6.2.4', 'refs/tags/6.3.0', 'refs/tags/6.2.3', 'refs/tags/2014.1.b2', 'refs/tags/2014.1.b3', 'refs/tags/7.0.3', 'refs/tags/2014.1.b1']
Could not find branch 'stable/mitaka' among [u'stable/newton', u'stable/ocata', u'stable/pike']
earliest version to include is 5.1.0
looking for ref 'stable/mitaka' as 'refs/heads/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/remotes/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/stable/mitaka'
looking for ref 'stable/mitaka' as 'refs/tags/mitaka-eol'
found ref 'stable/mitaka' as 'refs/tags/mitaka-eol' at fdd01ca736877aa1a877ae4035ae41bb5f241311
ignoring null-merge commits
000001 fdd01ca736877aa1a877ae4035ae41bb5f241311 [u'5.1.3']
...

Using --earliest-version does work around this properly, FWIW.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539009
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=b9cf9a7371eec7f20089f51bbd12e78963a10960
Submitter: Zuul
Branch: master

commit b9cf9a7371eec7f20089f51bbd12e78963a10960
Author: Doug Hellmann <email address hidden>
Date: Mon Jan 29 14:38:18 2018 -0500

    support scanning closed stable branches

    The scanner was stopping too soon when reviewing the history of a
    branch for which the previous branch had been "closed" by deleting the
    branch and tagging it with an -eol tag. This fix treats closed -eol
    branches the same way as open stable branches, using new configuration
    options to allow projects that use different naming conventions to
    have the same benefits.

    Change-Id: I8024929a2a95e00df48ce56939d54c1569fe18c5
    Fixes-Bug: #1746076
    Signed-off-by: Doug Hellmann <email address hidden>