Configuring temporary URLs is too explicit: the values can often be autodetected

Bug #1737714 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Dmitry Tantsur

Bug Description

Namely,
* swift_endpoint_url can and should be fetched from the service catalog,
* swift_account is often enough AUTH_ + project ID of the service project,
* swift_temp_url_key can be fetched from swift, using the service project.

What makes it worse is that these values are not validated as part of the regular node validation, so a user only learns they are required when a deployment fails.

We should provide reasonable defaults for these, and allow to override them for an advanced configuration.

Revision history for this message
Dmitry Tantsur (divius) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/526429
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=83dd6a1c0ea0b2ec8059b90a3f7af5f2d766fef2
Submitter: Zuul
Branch: master

commit 83dd6a1c0ea0b2ec8059b90a3f7af5f2d766fef2
Author: Dmitry Tantsur <email address hidden>
Date: Thu Dec 7 16:23:18 2017 +0100

    Auto-detect the defaults for [glance]swift_{account,temp_url_key,endpoint_url}

    In many cases, including devstack and TripleO, the swift account to use
    is based on the project_id of the 'service' project, so it makes sense
    to use it as a default.

    Similarly, the temporary URL key can be fetches from Swift, using HEAD
    on the account used to access it.

    In both cases it is assumed that the same project is used by Ironic
    and Glance to access Swift. Explicit values have to be provided
    otherwise.

    Finally, the endpoint URL can be fetched from the service catalog. Care
    is taken to strip the /v1/AUTH_<tenant ID> suffix.

    Closes-Bug: #1737714
    Change-Id: I701899928f0f780939f17aabc59eb90593ba95f0

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 10.0.0

This issue was fixed in the openstack/ironic 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.