'next' link should not be generated for GET /nodes?limit=1&instance_uuid=<uuid>

Bug #1718683 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ruby Loo

Bug Description

For this request: GET /nodes?limit=1&instance_uuid=<uuid>, the response will include a 'next' link if there was a node with that instance_uuid. Except that this request can only return (at most) one node so there should not be a next link (besides the fact that the link it generates is incorrect).

Ruby Loo (rloo)
summary: - 'next' link generated for GET /nodes?limit=1&instance_uuid=<uuid>
+ 'next' link should not be generated for GET
+ /nodes?limit=1&instance_uuid=<uuid>
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/506205

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/506205
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=12399ffc797e6b69f5ca2ba15134a09dff025318
Submitter: Zuul
Branch: master

commit 12399ffc797e6b69f5ca2ba15134a09dff025318
Author: Ruby Loo <email address hidden>
Date: Thu Sep 21 10:11:53 2017 -0400

    Remove 'next' for GET /nodes?limit=1&instance_uuid=

    For a "GET /nodes?limit=1&instance_uuid=<uuid>" request that has a
    node that matches, the response would include a 'next' link.
    (Note that the generated 'next' link happens to be incorrect; it
    doesn't include 'instance_uuid'). However, at most one node can match
    the specified instance UUID, so we should not be returning any 'next'
    link.

    This fixes it so no 'next' link is returned.

    Change-Id: I4efe06652baf3423790c238d4a8d2bc5a736b3a5
    Closes-Bug: #1718683

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.2.0

This issue was fixed in the openstack/ironic 9.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.