OneView driver is not working for multitenancy scenario in ocata

Bug #1716023 reported by Saulo Aislan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Fellype Cavalcante

Bug Description

Due OneView need for shutdown the hardware for change the machine boot device, we have developed a workaround for wait the machine be completely off before changing its boot device [1].

Now, we need to change the `OneViewAgentDeployMixin` from OneView drivers in Ocata release because of multitenancy scenario. Here we can see that the ironic implementation of `AgentDeployMixin` has changed since multitenancy was introduced [2]. This implies that every change on those methods from `AgentDeployMixin` that be implemented for any contributor if this change is needed in OneView drivers, the OneView drivers maintainers need to copy and paste the new code, that means code duplication.

[1] First solution with OneViewAgentDeployMixin: https://github.com/openstack/ironic/blob/58a41817fde4088cbf4a51991ed71663f86348fb/ironic/drivers/modules/oneview/vendor.py#L92

[2] Multitenancy related lines: https://github.com/openstack/ironic/blob/dfa2fb6dcd4e5030d5e1cac52ddbf43c9a181950/ironic/drivers/modules/agent_base_vendor.py#L573

Changed in ironic:
status: New → Triaged
summary: - OneView drivers doesn't support multitenancy in ocata
+ OneView drivers is not working for multitenancy scenario in ocata
description: updated
description: updated
summary: - OneView drivers is not working for multitenancy scenario in ocata
+ OneView driver is not working for multitenancy scenario in ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/507632

Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → High
status: Triaged → In Progress
assignee: nobody → Fellype Cavalcante (fellypefca)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/ocata)

Reviewed: https://review.openstack.org/507632
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d6934de3ebf102162678b24c130c51128453e4f2
Submitter: Jenkins
Branch: stable/ocata

commit d6934de3ebf102162678b24c130c51128453e4f2
Author: Fellype Cavalcante <email address hidden>
Date: Tue Sep 26 14:17:49 2017 -0300

    Fix multitenancy scenario on OneView Driver

    Switching from provisioning to tenant network was missed in
    reboot_and_finish_deploy for OnView Driver.
    The affected code was completely removed in the Pike release,
    hence this patch is not a cherry-pick.

    Change-Id: I36920741640981b5e85bbb08bfc1e2beff0b605f
    Closes-Bug: #1716023

tags: added: in-stable-ocata
Revision history for this message
Ruby Loo (rloo) wrote :

I'm going to change the status of this to 'Fix released', since the patch that merged in stable/ocata has 'Closes-Bug: #1716023'.

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.4

This issue was fixed in the openstack/ironic 7.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (stable/ocata)

Change abandoned by Julia Kreger (<email address hidden>) on branch: stable/ocata
Review: https://review.opendev.org/489598

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.