Boot from volume fails when deploy interface is 'iscsi'

[Shivanand Tendulker]

Boot from volume fails if deploy interface is `iscsi`.

It fails with following errpr:-
"Failed to validate deploy or power info for node 3aa741d2-2b8b-4257-b204-e6bb3c7e0394. Error: Cannot validate image information for node 3aa741d2-2b8b-4257-b204-e6bb3c7e0394 because one or more parameters are missing from its instance_info. Missing are: ['ramdisk', 'kernel', 'image_source'] (HTTP 500)"

The issue is caused as we are unconditionally calling driver.boot.prepare_ramdisk() in iscsi_deploy.prepare()
https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L532-L533

It should return if its BFV and target volume has a bootable volume. Its taken care in 'agent' interface at agent.prepare()
https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L455-L459

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/499446

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499446
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=e9ecdbbadc6a5e2a0936830251ecd1d560bf017e
Submitter: Jenkins
Branch: master

commit e9ecdbbadc6a5e2a0936830251ecd1d560bf017e
Author: Shivanand Tendulker <email address hidden>
Date: Thu Aug 31 00:25:56 2017 -0400

    Boot from volume fails with 'iscsi' deploy interface

    When boot from volume is requested for a node with 'iscsi' deploy
    interface and no 'image_source' is provided in
    'node.instance_info'. It calls boot.prepare_ramdisk() and fails
    while trying to perform validation for 'image_source'. This commit
    fixes the issue.

    Closes-Bug: #1714147

    Change-Id: Ia3bad7f3325576ba091284f9b63b67a1b26cb3b7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499911

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499911
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=95f9751a6de6f9cfaf67a6301c2ef8f33ad75131
Submitter: Jenkins
Branch: stable/pike

commit 95f9751a6de6f9cfaf67a6301c2ef8f33ad75131
Author: Shivanand Tendulker <email address hidden>
Date: Fri Sep 1 02:34:48 2017 -0400

    Boot from volume fails with 'iscsi' deploy interface

    When boot from volume is requested for a node with 'iscsi' deploy
    interface and no 'image_source' is provided in
    'node.instance_info'. It calls boot.prepare_ramdisk() and fails
    while trying to perform validation for 'image_source'. This commit
    fixes the issue.

    Closes-Bug: #1714147
    (cherry picked from commit e9ecdbbadc6a5e2a0936830251ecd1d560bf017e)

    Change-Id: If8e51f4ed04cd7001bf68a8a6a4d2d2b40e43c62

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/500868

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500868
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=dd570c964929dc2eab81360977961da12888690d
Submitter: Jenkins
Branch: master

commit dd570c964929dc2eab81360977961da12888690d
Author: Ruby Loo <email address hidden>
Date: Tue Sep 5 10:58:32 2017 -0400

    [reno] Clarify fix for BFV & image_source

    This updates the release note for the boot-from-volume fix for nodes
    with iscsi deploy interface, trying to validate the image_source even
    though it wasn't specified. It clarifies what the failure had been and
    what was fixed.

    The original fix was at e9ecdbbadc6a5e2a0936830251ecd1d560bf017e.

    Change-Id: Ife73e56c05ac3b3d1ddd67044a732c1a82ba228b
    Related-Bug: #1714147

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/501258

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501258
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0db2ed2055c423d082da0cfea280029c4955a985
Submitter: Jenkins
Branch: stable/pike

commit 0db2ed2055c423d082da0cfea280029c4955a985
Author: Ruby Loo <email address hidden>
Date: Tue Sep 5 10:58:32 2017 -0400

    [reno] Clarify fix for BFV & image_source

    This updates the release note for the boot-from-volume fix for nodes
    with iscsi deploy interface, trying to validate the image_source even
    though it wasn't specified. It clarifies what the failure had been and
    what was fixed.

    The original fix was at e9ecdbbadc6a5e2a0936830251ecd1d560bf017e.

    Change-Id: Ife73e56c05ac3b3d1ddd67044a732c1a82ba228b
    Related-Bug: #1714147
    (cherry picked from commit dd570c964929dc2eab81360977961da12888690d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.2.0 release.