prepare_instance() is not called for whole disk images with 'agent' deploy interface

Bug #1713916 reported by Shivanand Tendulker
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Shivanand Tendulker

Bug Description

task.driver.boot.prepare_instance gets called only if the instance image is partition image. It is not getting called when whole disk image is used.

https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L287

This causes failure in ceratin cases wherein driver needs to perform the steps after provisioning images (both partition and whole disk). Ex. iLO driver needs to set boot mode and update secure boot settings as part of prepare_instance() after provisioning the image.
https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L495-L498

Tags: agent ilo
description: updated
Changed in ironic:
assignee: nobody → Shivanand Tendulker (stendulker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/499050

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → High
tags: added: agent ilo
Dmitry Tantsur (divius)
Changed in ironic:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.