The get_boot_device of oneview drivers is not capable of get persistent property from server_hardware's iLo

Bug #1706725 reported by Rodrigo Farias de Macedo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Hugo Nicodemos Brito

Bug Description

Today, OneView Drivers get_boot_device is returning a hard coded "True" on the following return,
https://github.com/openstack/ironic/blob/460b9f1f5ffc39e24950f8246d04a760d8631c81/ironic/drivers/modules/oneview/management.py#L161 ,
It is now necessary to consider the Server Hardware iLo's persistent information, to see when to enable one_time_boot feature.

Tags: oneview
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
Xavier (marcusrafael)
Changed in ironic:
assignee: nobody → Xavier (marcusrafael)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/491983

Changed in ironic:
status: Triaged → In Progress
Changed in ironic:
assignee: Xavier (marcusrafael) → Hugo Nicodemos (hugonicodemos)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/491983
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5de0ccccd69258b930ed8ab7b91ca3a1aad705c1
Submitter: Jenkins
Branch: master

commit 5de0ccccd69258b930ed8ab7b91ca3a1aad705c1
Author: Xavier <email address hidden>
Date: Wed Aug 9 01:55:29 2017 -0300

    Fix persistent information when getting boot device

    This patches fixes the get_boot_device methods for oneview drivers
    to consider onetime boot option on the machine's iLO. If onetime
    boot is set to 'Once' on iLO, the method will return persistent as
    False (not persistent), True otherwise (persistent).

    Change-Id: Iae837a304003cb6c17d5c40d039469b418c97421
    Closes-Bug: #1706725

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.2.0

This issue was fixed in the openstack/ironic 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/524616

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/524616
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5847431e9cbf5705f5bf5b1b52d5cd50d27e6f87
Submitter: Zuul
Branch: master

commit 5847431e9cbf5705f5bf5b1b52d5cd50d27e6f87
Author: Hugo Nicodemos <email address hidden>
Date: Fri Dec 1 11:00:24 2017 -0300

    Fix persistent information when getting boot device

    This patches fixes the get_boot_device methods for ``oneview``
    hardware type to consider onetime boot option on the machine's iLO.
    if onetime boot is set to 'Once' on iLO, the method will return
    persistent as False (not persistent), True otherwise (persistent).

    Change-Id: I48d8b01ff37263a19c889f242a7ce2a99eee597e
    Closes-Bug: #1706725

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 10.1.0

This issue was fixed in the openstack/ironic 10.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.